Despite `editorconfig-exclude-modes` containing `emacs-lisp-mode`, settings from `.editorconfig` applied to `init.el`

[eaibmz]

Hi,
i added emacs-lisp-mode to editorconfig-exclude-modes but settings from .editorconfig still have been applied to init.el.
The relevant .editorconfig is located in the parent folder of init.el.
I had to resort to editorconfig-after-apply-functionsand force my custom settings there.

Emacs: 30.2
editorconfig-emacs: f85ec97

Emacs config

(defun my/emacs-lisp-mode-setup()
  (bind-key "C-c C-k" 'eval-buffer)
  (setq indent-tabs-mode nil)
  (setq tab-width 2)
  (setq standard-indent 2)
  (setq lisp-indent-offset nil))

(add-hook 'emacs-lisp-mode-hook
          #'my/emacs-lisp-mode-setup())

(use-package editorconfig
  :config
  (dolist (mode '(emacs-lisp-mode lisp-mode))
    (map-delete editorconfig-indentation-alist mode))
  (setq editorconfig-lisp-use-default-indent t)
  (setq editorconfig-exclude-modes '(emacs-lisp-mode lisp-mode))
  (setq editorconfig-exclude-regexps
        (append editorconfig-exclude-regexps '("\\.org$" "\\.el$")))
  (add-hook 'editorconfig-after-apply-functions                                      ;; Only this helps !!!
            (lambda (props)
              (when (eq major-mode 'emacs-lisp-mode)
                (my/emacs-lisp-mode-setup))))
  (editorconfig-mode 1))

.editorconfig

[*]
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
charset = utf-8
indent_style = tab
indent_size = 8

[*.sql]
indent_style = space
indent_size = 4

[monnier]

Curious: have you tried it with the built-in EditorConfig support in Emacs or have you installed editorconfig-emacs to override Emacs's own EditorConfig support?
[ The two are closely related, but aren't 100% in-sync yet. ☹️ ]

[eaibmz]

Curious: have you tried it with the built-in EditorConfig support in Emacs or have you installed editorconfig-emacs to override Emacs's own EditorConfig support? [ The two are closely related, but aren't 100% in-sync yet. ☹️ ]

I'm using straight.el, so overriding the built-in one.

[monnier]

Could you try it after uninstalling the editorconfig-emacs package?
AFAIK the built-in version of the package should do the right thing for you even without messing with editorconfig-exclude-* (which aren't supported in that version of the package anyway) because it applies the editorconfig settings before running the major mode hook.

[eaibmz]

My findings.
Replacing the git editorconfig-emacs with Fedora's official editorconfig-emacs package makes editorconfig-exclude-modes work as expected, and i no longer need to use editorconfig-after-apply-functions, but w/o editorconfig-exclude-modes
it still overrides my custom elisp settings with .editorconfig ones.

I'm confused, why is the latest git version of editorconfig-emacs is not working with editorconfig-exclude-modes as expected ?

[monnier]

I'm confused: why not try without any editorconfig-emacs package at all, since Emacs-30 comes with built-in support for editorconfig?

[eaibmz]

I'm confused: why not try without any editorconfig-emacs package at all, since Emacs-30 comes with built-in support for editorconfig?

My fault, i didn't explain it clearly, sorry. I mean the Fedora package editorconfig-emacs which just installs the built-in
editorconfig package under /usr/share/emacs/30.2/lisp/.

[monnier]

No, I really meant without any editorconfig-emacs package at all.

This said, I just took another look and my memory was wrong: hack-local-variables is called after running the mode hook, so the dir-local variables take precedence over the settings in emacs-lisp-mode-hook.

That's also true if you set them via .dir-locals.el rather than .editorconfig.
The reason it's done this way is accidental in that it's the same code that handles the file-local settings, and it makes sense for those to have precedence over the mode hook settings.

I suggest you M-x report-emacs-bug (requesting that dir-local settings have lower priority than mode hook settings), but in the mean time, the best I can offer is:

(defun my/emacs-lisp-mode-setup ()
  ;; Delay the settings after .editorconfig and .dir-locals.el settings.
  (add-hook 'after-change-major-mode-hook
	    #'my/delayed-emacs-lisp-mode-setup nil t))

(defun my/delayed-emacs-lisp-mode-setup ()
  (bind-key "C-c C-k" #'eval-buffer)
  (setq indent-tabs-mode nil)
  (setq tab-width 2)
  (setq standard-indent 2)
  (setq lisp-indent-offset nil))

(add-hook 'emacs-lisp-mode-hook #'my/emacs-lisp-mode-setup)

(use-package editorconfig
  :config
  (editorconfig-mode 1))

[eaibmz]

No, I really meant without any editorconfig-emacs package at all.

Hmm, removing the Fedora package makes editorconfig no longer available, Emacs can no longer find it.
I think this is the built-in editorconfig but in Fedora it's just a separate package which must be first installed.
Or do you mean editorconfig is compiled-in into Emacs binary ?

This said, I just took another look and my memory was wrong: hack-local-variables is called after running the mode hook, so the dir-local variables take precedence over the settings in emacs-lisp-mode-hook.

That's also true if you set them via .dir-locals.el rather than .editorconfig. The reason it's done this way is accidental in that it's the same code that handles the file-local settings, and it makes sense for those to have precedence over the mode hook settings.

I suggest you M-x report-emacs-bug (requesting that dir-local settings have lower priority than mode hook settings), but in the mean time, the best I can offer is:

(defun my/emacs-lisp-mode-setup ()
  ;; Delay the settings after .editorconfig and .dir-locals.el settings.
  (add-hook 'after-change-major-mode-hook
	    #'my/delayed-emacs-lisp-mode-setup nil t))

(defun my/delayed-emacs-lisp-mode-setup ()
  (bind-key "C-c C-k" #'eval-buffer)
  (setq indent-tabs-mode nil)
  (setq tab-width 2)
  (setq standard-indent 2)
  (setq lisp-indent-offset nil))

(add-hook 'emacs-lisp-mode-hook #'my/emacs-lisp-mode-setup)

(use-package editorconfig
  :config
  (editorconfig-mode 1))

Thanks for explaining!

[monnier]

Yes, editorconfig support is included in Emacs itself since Emac-30.