js2-mode does not respect indent

[Silex]

I found out that js2-mode does not respect indent, but simply doing M-x js-mode does.

Here's my config:

root = true

[*]
# Use spaces for indentation
indent_style = space
# Each indent should contain 2 spaces
indent_size = 2
# Use Unix line endings
end_of_line = lf
# The files are utf-8 encoded
charset = utf-8
# No whitespace at the end of line
trim_trailing_whitespace = true
# A file must end with an empty line - this is good for version control systems
insert_final_newline = true
# A line should not have more than this amount of chars (not supported by all plugins)
max_line_length = 120

[{Makefile,**.mk}]
# Use tabs for indentation (Makefiles require tabs)
indent_style = tab

[*.py]
indent_size = 4

[python]
indent_size = 4

[*.cs]
indent_size = 4

With js2-mode (the default) it indents to 4 spaces, with js-mode it correctly indents to 2 spaces.

M-x editorconfig-find-current-editorconfig works with both modes.

[monnier]

I cannot reproduce this with Emacs-30 (using the version of editorconfig-mode that's bundled with it).
The only detail I notice is that with js2-mode, I get prompted whether to accept the dir-local setting of js2-basic-offset because apparently this variable lacks any information of what is a safe value for it (this is a problem in the js2 package).

[monnier]

Side note: setting things like charset and insert_final_newline for all files is a recipe for nasty surprises if you ever need to look at binary files.

[Silex]

I cannot reproduce this with Emacs-30 (using the version of editorconfig-mode that's bundled with it).

I'll try to make a test case.

Side note: setting things like charset and insert_final_newline for all files is a recipe for nasty surprises if you ever need to look at binary files.

What do you recommend? Is there a code or something generic to mean text files?

[Silex]

OK here's a testcase: https://github.com/Silex/editorconfig-emacs/tree/js2-mode-bug/testcase

The output is this:

philippe@stvs-pv-laptop-01:~/work/stvs/licenses-manager/testcase$ docker run -it --rm -v "$PWD":/data silex/emacs:30.2   emacs --batch -Q -l /data/test.el
Importing package-keyring.gpg...
Importing package-keyring.gpg...done
Contacting host: elpa.gnu.org:443
Contacting host: elpa.gnu.org:443
Package refresh done
Contacting host: elpa.nongnu.org:443
Package refresh done
Setting `package-selected-packages' temporarily since "emacs -q" would overwrite customizations
Setting `package-selected-packages' temporarily since "emacs -q" would overwrite customizations
Contacting host: elpa.gnu.org:443
Contacting host: elpa.gnu.org:443
Parsing tar file...
Parsing tar file...done
Extracting... \
Extracting...done
  INFO     Scraping 4 files for loaddefs...
  INFO     Scraping 4 files for loaddefs...done
  GEN      js2-mode-autoloads.el
Checking /root/.emacs.d/elpa/js2-mode-20231224...
Compiling /root/.emacs.d/elpa/js2-mode-20231224/js2-imenu-extras.el...
Compiling /root/.emacs.d/elpa/js2-mode-20231224/js2-mode-autoloads.el...
Compiling /root/.emacs.d/elpa/js2-mode-20231224/js2-mode-pkg.el...

In toplevel form:
js2-mode-pkg.el:1:1: Warning: file has no `lexical-binding' directive on its first line
Compiling /root/.emacs.d/elpa/js2-mode-20231224/js2-mode.el...

In toplevel form:
js2-mode.el:223:9: Warning: defvar `js2-typed-array-externs' docstring wider than 80 characters
js2-mode.el:781:29: Warning: avoid `lsh'; use `ash' instead
js2-mode.el:824:10: Warning: in defcustom for `js2-global-externs': `list' without arguments
js2-mode.el:1141:10: Warning: in defcustom for `js2-warn-about-unused-function-arguments': `booleanp' is not a valid type

In js2-same-line:
js2-mode.el:2132:17: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.
js2-mode.el:2133:17: Warning: `point-at-eol' is an obsolete function (as of 29.1); use `line-end-position' or `pos-eol' instead.

In js2-always-defined-boolean-p:
js2-mode.el:5501:22: Warning: `eq' called with literal float that may never match (arg 2)

In js2-x-digit-to-int:
js2-mode.el:5858:16: Warning: avoid `lsh'; use `ash' instead

In js2--classify-variable:
js2-mode.el:7342:2: Warning: docstring wider than 80 characters

In js2-parse:
js2-mode.el:8233:32: Warning: `max-specpdl-size' is an obsolete variable (as of 29.1).
js2-mode.el:8233:10: Warning: `max-specpdl-size' is an obsolete variable (as of 29.1).
js2-mode.el:8229:10: Warning: `inhibit-point-motion-hooks' is an obsolete variable (as of 25.1); use `cursor-intangible-mode' or `cursor-sensor-mode' instead

In js2-check-inconsistent-return-warning:
js2-mode.el:8500:24: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-parse-statement:
js2-mode.el:8658:43: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-parse-warn-missing-semi:
js2-mode.el:8701:21: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-parse-variables:
js2-mode.el:9772:2: Warning: docstring wider than 80 characters

In js2-parse-primary-expr:
js2-mode.el:10770:23: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-arglist-close:
js2-mode.el:11474:17: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-indent-looks-like-label-p:
js2-mode.el:11479:15: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-indent-case-block-p:
js2-mode.el:11514:17: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-bounce-indent:
js2-mode.el:11564:35: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.
js2-mode.el:11566:49: Warning: `point-at-eol' is an obsolete function (as of 29.1); use `line-end-position' or `pos-eol' instead.
js2-mode.el:11580:35: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.
js2-mode.el:11587:43: Warning: `point-at-eol' is an obsolete function (as of 29.1); use `line-end-position' or `pos-eol' instead.

In js2-indent-bounce:
js2-mode.el:11694:10: Warning: `inhibit-point-motion-hooks' is an obsolete variable (as of 25.1); use `cursor-intangible-mode' or `cursor-sensor-mode' instead
js2-mode.el:11696:40: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-error-buffer-jump:
js2-mode.el:11864:37: Warning: Unused lexical argument `ignored'

In js2-beginning-of-line:
js2-mode.el:12329:19: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-end-of-line:
js2-mode.el:12336:17: Warning: `point-at-eol' is an obsolete function (as of 29.1); use `line-end-position' or `pos-eol' instead.

In js2-mode-extend-//-comment:
js2-mode.el:12550:15: Warning: `point-at-eol' is an obsolete function (as of 29.1); use `line-end-position' or `pos-eol' instead.
js2-mode.el:12556:20: Warning: `point-at-eol' is an obsolete function (as of 29.1); use `line-end-position' or `pos-eol' instead.

In js2-mode-toggle-//-comment:
js2-mode.el:12576:16: Warning: `point-at-eol' is an obsolete function (as of 29.1); use `line-end-position' or `pos-eol' instead.
Compiling /root/.emacs.d/elpa/js2-mode-20231224/js2-old-indent.el...

In js2-end-of-do-while-loop-p:
js2-old-indent.el:269:47: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.
js2-old-indent.el:276:43: Warning: `point-at-eol' is an obsolete function (as of 29.1); use `line-end-position' or `pos-eol' instead.

In js2-ctrl-statement-indentation:
js2-old-indent.el:324:50: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-proper-indentation:
js2-old-indent.el:434:29: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2-indent-line:
js2-old-indent.el:489:10: Warning: `inhibit-point-motion-hooks' is an obsolete variable (as of 25.1); use `cursor-intangible-mode' or `cursor-sensor-mode' instead
js2-old-indent.el:491:40: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.

In js2--expression-in-sgml-indent-line:
js2-old-indent.el:672:11: Warning: `inhibit-point-motion-hooks' is an obsolete variable (as of 25.1); use `cursor-intangible-mode' or `cursor-sensor-mode' instead
js2-old-indent.el:674:40: Warning: `point-at-bol' is an obsolete function (as of 29.1); use `line-beginning-position' or `pos-bol' instead.
Done (Total of 3 files compiled, 2 skipped)
Package `js2-mode' installed.
editorconfig: /data/.editorconfig
[js-mode] ---------- BEFORE INDENT ----------

export function update() {
  document.getElementById('test').textContent = 'foo';
}

Indenting region...
Indenting region...done
[js-mode] ---------- AFTER INDENT ----------

export function update() {
  document.getElementById('test').textContent = 'foo';
}

[js2-mode] ---------- BEFORE INDENT ----------

export function update() {
  document.getElementById('test').textContent = 'foo';
}

Indenting region...
Indenting region...done
[js2-mode] ---------- AFTER INDENT ----------

export function update() {
    document.getElementById('test').textContent = 'foo';
}

As you can see js-mode indents properly but js2-mode does not.