Support systems with 128-bit pointers. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow meaningful comparisons between 32- and 64-bit systems, core_list_init hardcodes the size of pointers to be 8 bytes. This controls the number list elements allocated for a buffer of a given size. On a system with 128-bit pointers this results in data corruption as the list data is written over list_head objects. Address this by adding a POINTER_SPACE define which can be changed to 16. Update the checksums in the known_crc arrays for the run1.log and run2.log cases.
Contributor
Author
|
I don't necessarily expect this to be merged as is, but I'd like to start a discussion about how to support systems with 128-bit pointers. Our processors (http://chericpu.org) have 128-bit pointers. We have a variant for MIPS, we're working on one for RISC-V, and we've been working with Arm (who will be producing the Morello prototype architecture over the next couple years https://www.cl.cam.ac.uk/research/security/ctsrd/cheri/cheri-morello.html). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow meaningful comparisons between 32- and 64-bit systems,
core_list_init hardcodes the size of pointers to be 8 bytes. This
controls the number list elements allocated for a buffer of a given
size. On a system with 128-bit pointers this results in data corruption
as the list data is written over list_head objects.
Address this by adding a POINTER_SPACE define which can be changed to
16. Update the checksums in the known_crc arrays for the run1.log and
run2.log cases.