new_ functions do not play well with embeds

[hqm42]

Example:

# foos.ex
defmodule Foos do
  use ContextKit.CRUD,
    repo: MyRepo,
    schema: Foo,
    queries: __MODULE__
end

# foos/foo.ex

defmodule Foos.Foo do
  use Ecto.Schema

  import Ecto.Changeset

  schema "foos" do
    embeds_one :bar, Bars.Bar, on_replace: :delete
  end

  def changeset(foo, attrs) do
    foo
    |> cast(attrs, [])
    |> cast_embeded(:bar)
  end
end

iex(localportal@localhost)1> Foos.new_foo
** (RuntimeError) casting embeds with cast/4 for :bar field is not supported, use cast_embed/3 instead

Why isn't new_ implemented as follows?

        @spec unquote(:"new_#{resource_name}")(params :: map(), opts :: keyword()) :: unquote(schema).t()
        def unquote(:"new_#{resource_name}")(params, opts) when is_map(params) and is_list(opts) do
          record =
            unquote(schema).__struct__()
            |> unquote(schema).changeset(params)
            |> Ecto.Changeset.apply_changes()

          if opts[:preload], do: unquote(repo).preload(record, opts[:preload]), else: record
        end

[egze]

I never needed embeds before. I'll have a look later today.

[egze]

@hqm42 Can you test with master and let me know?

For future I'm thinking to make the changeset function name configurable for each type of function. Because currently the assumption is that everybody will have a changeset/2 function in the schema.

So we can have something like this:

defmodule MyApp.Blog do
  use ContextKit.CRUD,
    repo: MyApp.Repo,
    schema: MyApp.Blog.Comment,
    queries: MyApp.Blog.CommentQueries,
    changesets: [
      new: MyApp.Blog.Comment.changeset/2,
      create: MyApp.Blog.Comment.create_changeset/2,
    ]
end

[hqm42]

Thank you for the update! Now it works for me.