move lightning to extras, disable keras tests

we need TF 1.x but it does not work on python 3.9+

Author: lopuhin

.github/workflows/python-package.yml

@@ -17,9 +17,9 @@ jobs:
       fail-fast: false
       matrix:
         include:
-            - python-version: '3.12'
+            - python-version: '3.10'
               tox-env: 'mypy'
-            - python-version: '3.12'
+            - python-version: '3.10'
               tox-env: 'docs'
             - python-version: '3.9'
               tox-env: 'py39'

tox.ini

@@ -28,21 +28,18 @@ deps=
     {[base]deps}
     ipython
     pandas
+    sklearn-crfsuite
 commands=
-    ; to install lightning numpy and Cython must be installed first
-    pip install Cython
-    pip install joblib "sklearn-contrib-lightning >= 0.4" --no-binary sklearn-contrib-lightning
     pip install -e .
     py.test --doctest-modules \
             --ignore eli5/xgboost.py \
             --ignore eli5/lightgbm.py \
             --ignore eli5/catboost.py \
             --ignore eli5/keras \
-            --ignore eli5/sklearn_crfsuite \
+            --ignore eli5/lightning.py \
             --ignore eli5/formatters/image.py \
             --ignore tests/utils_image.py \
             --cov=eli5 --cov-report=html --cov-report=term {posargs: eli5 tests}
-    ; TODO once sklearn-crfsuite is compatible, stop ignoring eli5/sklearn_crfsuite
 
 
 [testenv:py310-extra]
@@ -52,11 +49,14 @@ deps=
     xgboost
     lightgbm != 2.0.5, != 2.0.6
     catboost
-    tensorflow
-    keras
+    # tensorflow
+    # keras
     matplotlib
     Pillow
 commands=
+    ; to install lightning numpy and Cython must be installed first
+    pip install Cython
+    pip install joblib "sklearn-contrib-lightning >= 0.4" --no-binary sklearn-contrib-lightning
     pip install -e .
     ; run tests for extra dependencies
     py.test --doctest-modules \
@@ -68,15 +68,14 @@ commands=
             --ignore tests/test_sklearn_vectorizers.py \
             --ignore tests/test_utils.py \
             --ignore eli5/lightning.py \
-            --ignore eli5/sklearn_crfsuite \
+            --ignore eli5/keras \
             --cov=eli5 --cov-report=html --cov-report=term {posargs: eli5 tests}
 
 
 [testenv:py310-nodeps]
 deps=
     {[base]deps}
 commands=
-; without lightning as it is optional
     pip install -e .
     py.test --doctest-modules \
             --ignore eli5/lightning.py \
@@ -93,7 +92,7 @@ commands=
 
 
 [testenv:mypy]
-basepython=python3.12
+basepython=python3.10
 deps=
     {[testenv]deps}
     mypy == 0.750
@@ -103,6 +102,7 @@ commands=
 
 
 [testenv:docs]
+basepython=python3.10
 deps=
     mock==1.0.1
     pillow==8.3.1