Rename build telemetry JSON keys #2835
Conversation
fractalwrench
left a comment
fractalwrench
left a comment
There was a problem hiding this comment.
LGTM, assuming that backend folks are ok with this migration. Will the existing keys still be supported for older plugin versions so we don't entirely lose insight on those older versions?
| @@ -116,6 +118,19 @@ class BuildTelemetryCollector { | |||
| null | |||
| } | |||
| } | |||
|
|
|||
| private fun getKotlinJvmTarget(project: Project): String? { | |||
| return if (project.pluginManager.hasPlugin("org.jetbrains.kotlin.android")) { | |||
There was a problem hiding this comment.
This is probably good enough for our purposes. jvm or multiplatform could also be in play but should be much less common.
There was a problem hiding this comment.
This is definitely something we should revisit in the future.
If we end up refactoring the build telemetry process, one of the things we could do is call withPlugin with the three options, jvm, android and multiplatform, get the data from the first one we get, and ignore the rest.
|
@fractalwrench yep, working on it
|
priettt
changed the base branch from
main
to
priettt/kotlinJvmTargetTelemetry
priettt
force-pushed
the
priettt/buildTelemetryRename
branch
from
2c1a87e to
1fe316f
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Goal
Improve readability of build telemetry JSON API by replacing abbreviated keys with descriptive names.