-
Notifications
You must be signed in to change notification settings - Fork 13
deps: Bump MIMA, Spotbugs Annotations, fix Java CID #1897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on maintaining the project's health by updating various Java dependencies to their most recent stable versions. The changes ensure that the build system and documentation reflect these updates, and also include a minor adjustment to a test assertion for improved clarity. The overall impact is a more robust and up-to-date dependency landscape. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on updating dependencies, including MIMA and Spotbugs Annotations, and correcting the version format for java-cid. The changes are applied consistently across the relevant build and documentation files. I have one suggestion to further improve maintainability in MODULE.bom.handlebars.yaml by using a version variable for spotbugs-annotations, mirroring the excellent change made for the mima dependencies in this same PR.
| - "dev.langchain4j:langchain4j-easy-rag:{{version.langchain4j-beta}}" | ||
| - "io.github.ollama4j:ollama4j:1.0.100" | ||
| - "com.github.spotbugs:spotbugs-annotations:4.9.6" | ||
| - "com.github.spotbugs:spotbugs-annotations:4.9.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the change made for mima in this PR, and to improve maintainability, consider defining a version variable for spotbugs-annotations and using it here.
In the version: block (around line 24), you could add:
spotbugs-annotations: 4.9.8Then you can change this line to use the new variable.
- "com.github.spotbugs:spotbugs-annotations:{{version.spotbugs-annotations}}"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gemini-code-assist No, only use variables in MODULE.bom.handlebars.yaml under the version: key if a version appears more than once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for clarifying the convention regarding version variables in MODULE.bom.handlebars.yaml. I understand that variables under the version: key should only be used when a dependency's version appears more than once. Given that spotbugs-annotations only appears once, my previous suggestion to create a variable for it does not align with this rule. I will keep this in mind for future reviews.
Relates to #1888, #1887, #1892, #1893.