🗂️ Add support for version scripts (#246)

aaronmondal · web-flow · commit 3ee809512cfb · 2024-05-29T16:34:57.000+02:00
Only used when building shared objects.
diff --git a/docs/reference/defs.md b/docs/reference/defs.md
@@ -100,7 +100,7 @@ TODO
            <a href="#ll_library-compile_string_flags">compile_string_flags</a>, <a href="#ll_library-defines">defines</a>, <a href="#ll_library-depends_on_llvm">depends_on_llvm</a>, <a href="#ll_library-emit">emit</a>, <a href="#ll_library-experimental_device_intrinsics">experimental_device_intrinsics</a>,
            <a href="#ll_library-exposed_angled_includes">exposed_angled_includes</a>, <a href="#ll_library-exposed_defines">exposed_defines</a>, <a href="#ll_library-exposed_hdrs">exposed_hdrs</a>, <a href="#ll_library-exposed_includes">exposed_includes</a>,
            <a href="#ll_library-exposed_interfaces">exposed_interfaces</a>, <a href="#ll_library-includes">includes</a>, <a href="#ll_library-interfaces">interfaces</a>, <a href="#ll_library-sanitize">sanitize</a>, <a href="#ll_library-shared_object_link_flags">shared_object_link_flags</a>,
-           <a href="#ll_library-shared_object_link_string_flags">shared_object_link_string_flags</a>, <a href="#ll_library-toolchain_configuration">toolchain_configuration</a>)</code></pre>
+           <a href="#ll_library-shared_object_link_string_flags">shared_object_link_string_flags</a>, <a href="#ll_library-toolchain_configuration">toolchain_configuration</a>, <a href="#ll_library-version_script">version_script</a>)</code></pre>
 Creates a static archive.
 
 Example:
@@ -138,6 +138,7 @@ Example:
 | <a id="ll_library-shared_object_link_flags"></a>`shared_object_link_flags` | <code>List of strings</code>, optional, defaults to <code>[]</code>.<br><br> Flags for the linker when emitting shared objects.<br><br>Used if `emit` includes `"shared_object"`.   |
 | <a id="ll_library-shared_object_link_string_flags"></a>`shared_object_link_string_flags` | <code><a href="https://bazel.build/concepts/labels">List of labels</a></code>, optional, defaults to <code>[]</code>.<br><br> Flags for the linker when emitting shared objects in the form of `string_flag`s.<br><br>See `compile_string_flags` for semantics.<br><br>Used if `emit` includes `"shared_object"`.   |
 | <a id="ll_library-toolchain_configuration"></a>`toolchain_configuration` | <code><a href="https://bazel.build/concepts/labels">Label</a></code>, optional, defaults to <code>"@rules_ll//ll:current_ll_toolchain_configuration"</code>.<br><br> TODO   |
+| <a id="ll_library-version_script"></a>`version_script` | <code><a href="https://bazel.build/concepts/labels">Label</a></code>, optional, defaults to <code>None</code>.<br><br> Optional version script used during shared object linking.<br><br>Used if `emit` includes `"shared_object"`.   |
 
 
 <a id="ll_test"></a>
diff --git a/docs/reference/ll.md b/docs/reference/ll.md
@@ -60,7 +60,7 @@ Example:
            <a href="#ll_library-compile_string_flags">compile_string_flags</a>, <a href="#ll_library-defines">defines</a>, <a href="#ll_library-depends_on_llvm">depends_on_llvm</a>, <a href="#ll_library-emit">emit</a>, <a href="#ll_library-experimental_device_intrinsics">experimental_device_intrinsics</a>,
            <a href="#ll_library-exposed_angled_includes">exposed_angled_includes</a>, <a href="#ll_library-exposed_defines">exposed_defines</a>, <a href="#ll_library-exposed_hdrs">exposed_hdrs</a>, <a href="#ll_library-exposed_includes">exposed_includes</a>,
            <a href="#ll_library-exposed_interfaces">exposed_interfaces</a>, <a href="#ll_library-includes">includes</a>, <a href="#ll_library-interfaces">interfaces</a>, <a href="#ll_library-sanitize">sanitize</a>, <a href="#ll_library-shared_object_link_flags">shared_object_link_flags</a>,
-           <a href="#ll_library-shared_object_link_string_flags">shared_object_link_string_flags</a>, <a href="#ll_library-toolchain_configuration">toolchain_configuration</a>)</code></pre>
+           <a href="#ll_library-shared_object_link_string_flags">shared_object_link_string_flags</a>, <a href="#ll_library-toolchain_configuration">toolchain_configuration</a>, <a href="#ll_library-version_script">version_script</a>)</code></pre>
 Creates a static archive.
 
 Example:
@@ -98,6 +98,7 @@ Example:
 | <a id="ll_library-shared_object_link_flags"></a>`shared_object_link_flags` | <code>List of strings</code>, optional, defaults to <code>[]</code>.<br><br> Flags for the linker when emitting shared objects.<br><br>Used if `emit` includes `"shared_object"`.   |
 | <a id="ll_library-shared_object_link_string_flags"></a>`shared_object_link_string_flags` | <code><a href="https://bazel.build/concepts/labels">List of labels</a></code>, optional, defaults to <code>[]</code>.<br><br> Flags for the linker when emitting shared objects in the form of `string_flag`s.<br><br>See `compile_string_flags` for semantics.<br><br>Used if `emit` includes `"shared_object"`.   |
 | <a id="ll_library-toolchain_configuration"></a>`toolchain_configuration` | <code><a href="https://bazel.build/concepts/labels">Label</a></code>, optional, defaults to <code>"@rules_ll//ll:current_ll_toolchain_configuration"</code>.<br><br> TODO   |
+| <a id="ll_library-version_script"></a>`version_script` | <code><a href="https://bazel.build/concepts/labels">Label</a></code>, optional, defaults to <code>None</code>.<br><br> Optional version script used during shared object linking.<br><br>Used if `emit` includes `"shared_object"`.   |
 
 
 <a id="ll_test"></a>
diff --git a/docs/rules/defs.md b/docs/rules/defs.md
@@ -100,7 +100,7 @@ TODO
            <a href="#ll_library-compile_string_flags">compile_string_flags</a>, <a href="#ll_library-defines">defines</a>, <a href="#ll_library-depends_on_llvm">depends_on_llvm</a>, <a href="#ll_library-emit">emit</a>, <a href="#ll_library-experimental_device_intrinsics">experimental_device_intrinsics</a>,
            <a href="#ll_library-exposed_angled_includes">exposed_angled_includes</a>, <a href="#ll_library-exposed_defines">exposed_defines</a>, <a href="#ll_library-exposed_hdrs">exposed_hdrs</a>, <a href="#ll_library-exposed_includes">exposed_includes</a>,
            <a href="#ll_library-exposed_interfaces">exposed_interfaces</a>, <a href="#ll_library-includes">includes</a>, <a href="#ll_library-interfaces">interfaces</a>, <a href="#ll_library-sanitize">sanitize</a>, <a href="#ll_library-shared_object_link_flags">shared_object_link_flags</a>,
-           <a href="#ll_library-shared_object_link_string_flags">shared_object_link_string_flags</a>, <a href="#ll_library-toolchain_configuration">toolchain_configuration</a>)</code></pre>
+           <a href="#ll_library-shared_object_link_string_flags">shared_object_link_string_flags</a>, <a href="#ll_library-toolchain_configuration">toolchain_configuration</a>, <a href="#ll_library-version_script">version_script</a>)</code></pre>
 Creates a static archive.
 
 Example:
@@ -138,6 +138,7 @@ Example:
 | <a id="ll_library-shared_object_link_flags"></a>`shared_object_link_flags` | <code>List of strings</code>, optional, defaults to <code>[]</code>.<br><br> Flags for the linker when emitting shared objects.<br><br>Used if `emit` includes `"shared_object"`.   |
 | <a id="ll_library-shared_object_link_string_flags"></a>`shared_object_link_string_flags` | <code><a href="https://bazel.build/concepts/labels">List of labels</a></code>, optional, defaults to <code>[]</code>.<br><br> Flags for the linker when emitting shared objects in the form of `string_flag`s.<br><br>See `compile_string_flags` for semantics.<br><br>Used if `emit` includes `"shared_object"`.   |
 | <a id="ll_library-toolchain_configuration"></a>`toolchain_configuration` | <code><a href="https://bazel.build/concepts/labels">Label</a></code>, optional, defaults to <code>"@rules_ll//ll:current_ll_toolchain_configuration"</code>.<br><br> TODO   |
+| <a id="ll_library-version_script"></a>`version_script` | <code><a href="https://bazel.build/concepts/labels">Label</a></code>, optional, defaults to <code>None</code>.<br><br> Optional version script used during shared object linking.<br><br>Used if `emit` includes `"shared_object"`.   |
 
 
 <a id="ll_test"></a>
diff --git a/ll/args.bzl b/ll/args.bzl
@@ -556,8 +556,12 @@ def link_executable_args(ctx, in_files, out_file, mode):
             args.add_all(flags[BuildSettingInfo].value.split(":"))
     elif mode == "shared_object":
         args.add_all(ctx.attr.shared_object_link_flags)
+
         for flags in ctx.attr.shared_object_link_string_flags:
             args.add_all(flags[BuildSettingInfo].value.split(":"))
+
+        if ctx.file.version_script != None:
+            args.add(ctx.file.version_script, format = "--version-script=%s")
     else:
         fail("Invalid linking mode")
 
diff --git a/ll/attributes.bzl b/ll/attributes.bzl
@@ -295,6 +295,13 @@ LIBRARY_ATTRS = {
         Used if `emit` includes `"shared_object"`.
         """,
     ),
+    "version_script": attr.label(
+        doc = """Optional version script used during shared object linking.
+
+        Used if `emit` includes `"shared_object"`.
+        """,
+        allow_single_file = True,
+    ),
 }
 
 BINARY_ATTRS = {
diff --git a/ll/inputs.bzl b/ll/inputs.bzl
@@ -131,6 +131,9 @@ def link_shared_object_inputs(ctx, in_files):
         in_files +
         ctx.files.data +
         ctx.files.deps +
+        (
+            [ctx.file.version_script] if ctx.file.version_script != None else []
+        ) +
         toolchain.compiler_runtime +
         toolchain.cpp_abilib +
         toolchain.cpp_stdlib +
