Skip to content

Improve bool definitions and execution behavior #487

@displague

Description

@displague

In #485, @stevemar, @ctreatma, and I discussed that while the precedent in metal-cli is for bool's to have --name=<true|false>, there is at least one exception with --app vs --sms for TFA.

We also discussed that in places where --name=false is used, we may not be handling it properly, where false values must be explicitly sent in API calls. These parameters are confusing to specify, and with Cobra, it is easy to miss incorrect handling during code review.

Metal CLI should adopt more obvious patterns for bools, such as named pairs (lock, unlock) or --no- prefixes.

It would be great to get these improvements from upstream project(s), but it can be implemented locally:

Originally posted by @displague in #485 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions