Skip to content

Conversation

@bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Nov 10, 2025

This adds a way to specify a rom-elf ( see https://github.com/espressif/esp-rom-elfs )

The additional ELF will be used to resolve names, e.g. on ESP32-S3

Before

image

After

image

It is also used by the stack-dump analyzer used on RISC-V if stack frames are not enabled

Before (ESP32-S3)

image

After

image

@bjoernQ bjoernQ marked this pull request as ready for review November 10, 2025 12:59
@bugadani
Copy link
Contributor

IMHO the default should be that espflash tries to figure out the chip revision and loads the appropriate elf automatically, there should be no need to faff about with the elfs unless the user uses a chip that is not supported.

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Nov 10, 2025

IMHO the default should be that espflash tries to figure out the chip revision and loads the appropriate elf automatically, there should be no need to faff about with the elfs unless the user uses a chip that is not supported.

I thought about that but - the way we currently do things, we probably would add all the ROMs to the resources (increasing binary size) for something which is relatively rarely really needed 🤔

I don't have a strong oppinion about that however 🤷‍♂️

@bugadani
Copy link
Contributor

I'm not worried about the <1MB per however many devices we have, on the other hand managing this by hand is very annoying.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure about whats the best approach for storing the elfs though, but we can go with this way until we see it becomes an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants