feat: add NetworkUpgradeTxns library #18294
Draft
+442
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurelian
reviewed
Nov 14, 2025
Comment on lines
+23
to
+31
| struct NetworkUpgradeTxn { | ||
| bytes data; | ||
| address from; | ||
| uint64 gas; | ||
| bool isSystemTransaction; | ||
| uint256 mint; | ||
| bytes32 sourceHash; | ||
| address to; | ||
| uint256 value; |
Contributor
There was a problem hiding this comment.
This field ordering feels off, let's have it follow the order in the DepositTx struct in deposit_tx.go
opgitgovernance
added
the
S-stale
Contributor
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Network Upgrade Transaction Lib
Adds Network Upgrade Transaction helper library as part of the
L2 Contracts Managerproject.Changes
NetworkUpgradeTxns.sol providing: