Battery discharge control should not be shown if not enabled or supported by battery

[andig]

This icon (right) is confusing:

[naltatis]

Will be reworked here #24449

[naltatis]

Battery discharge control should not be shown if not enabled or supported by battery

Just read the title. Please provide infos so I can reproduce. This should only be shown if a hold status is published, which should only be done if a controllable battery exists.

[andig]

Seems that's not the case. Happening with "stupid" custom battery meter.

[andig]

Seem's we're not checking if it even can be enabled:

func (site *Site) dischargeControlActive(rate api.Rate) bool {
	if !site.GetBatteryDischargeControl() {
		return false
	}

	for _, lp := range site.Loadpoints() {
		smartCostActive := site.smartCostActive(lp, rate)
		if lp.GetStatus() == api.StatusC && (smartCostActive || lp.IsFastChargingActive()) {
			return true
		}
	}

	return false
}

Not sure how I could enable it though.

[andig]

Indeed enabled for me:

 "batteryDischargeControl": true,