fix: ignore cfos 0.0 #24997
fix: ignore cfos 0.0 #24997
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `charger/cfos.go:170-171` </location>
<code_context>
-
- return float64(binary.BigEndian.Uint64(b)) / 1e3, nil
+ result := float64(binary.BigEndian.Uint64(b)) / 1e3
+ if result == 0.0 {
+ return 0, errors.New("cfos returned 0")
+ }
+ return result, nil
</code_context>
<issue_to_address>
**issue (bug_risk):** Returning an error for zero energy may mask legitimate zero readings.
Zero energy readings can occur legitimately, such as after initialization. Consider handling zero values without treating them as errors to prevent misclassification.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
charger/cfos.go
Outdated
| if result == 0.0 { | ||
| return 0, errors.New("cfos returned 0") |
There was a problem hiding this comment.
issue (bug_risk): Returning an error for zero energy may mask legitimate zero readings.
Zero energy readings can occur legitimately, such as after initialization. Consider handling zero values without treating them as errors to prevent misclassification.
|
A more robust approach might be to store previous read values in the CfosPowerBrain structure and return the stored value in case it reports 0. Only storing values that are not 0 then makes sure it never reports 0 except on completely new cfos chargers. |
caching now the previous value |
Co-authored-by: andig <[email protected]>
|
Änderungen übernommen. Danke. @andig ist ein Hinweis in https://github.com/evcc-io/docs/blob/main/docs/devices/chargers.mdx bzgl. der Instabilität der Wallbox bei 1p3p Umschaltungen die zu den regelmäßigen Neustarts gewünscht? |
3 participants
ignore invalid total kWh - cfos returns 0.0
see #12886 (reply in thread)