sh syntax error when running on windows

[NavyD]

Description

sh syntax error when running on windows: -c: line 3: syntax error: unexpected end of file .

lefthook.yml

colors: false
test:
  jobs:
    - name: test
      run: |
        if [ -z "$CI" ]; then
            echo "NO CI"
        else
            echo "CI"
        fi

Commands to reproduce

$ $env:LEFTHOOK_VERBOSE='true'

$ lefthook run test
│  [lefthook] git: git version
│             out: git version 2.51.0.windows.2
│  [lefthook] git: git rev-parse --path-format=absolute --show-toplevel --git-path hooks --git-path info --git-dir
│             out: C:/Users/xxxx/workspaces/projects/xxx
│                  C:/Users/xxxx/workspaces/projects/xxx/.git/hooks
│                  C:/Users/xxxx/workspaces/projects/xxx/.git/info
│                  C:/Users/xxxx/workspaces/projects/xxx/.git
│  loading config: C:\Users\xxxx\workspaces\projects\xxx\lefthook.yaml
╭──────────────────────────────╮
│ lefthook v1.13.6  hook: test │
╰──────────────────────────────╯
│  [lefthook] run: "C:\Program Files\Git\bin\sh.exe" -c "if [ -z "$CI" ]; then
│      echo "NO CI"
│  else
│      echo "CI"
│  fi
│  "
⠙ waiting: testCI
else
    echo CI
fi
: -c: line 3: syntax error: unexpected end of file
│  [lefthook] git: git diff --name-only --cached --diff-filter=ACMR
│  [lefthook] git: git diff --name-only --cached --diff-filter=ACMRD
│  [lefthook] git: git status --short --porcelain
│             out: M lefthook-nodejs.yaml
│                  M lefthook.yaml
│                  ?? CHANGELOG.md
┃  test ❯



  ────────────────────────────────────
summary: (done in 0.19 seconds)
✗ test (0.19 seconds)

Lefthook version

1.13.6 539f66c92f10e20ed369d769afee1cd6e93d5735

Possible solution

Thank you for creating this excellent software!

I found the problem occurs here:

lefthook/internal/run/controller/exec/exec_windows.go

Line 114 in 57a23f9

cmdLine := "\"" + sh + "\"" + " -c " + "\"" + cmdstr + "\""

I'm not familiar with the golang and don't understand why it can't be passed as a parameter like unix:

lefthook/internal/run/controller/exec/exec_unix.go

Line 82 in 57a23f9

command := exec.CommandContext(ctx, "sh", "-c", cmdstr)

Or we can also use a temp file or stdin for sh to read to avoid this problem.

[mrexox]

Oh, I guess it's the escaping issue with quotes 🤔 Windows behave not like *nix and doesn't allow single quotes. Thank you for creating this bug, I'll try finding the workaround!