Skip to content

Commit 7a67dcb

Browse files
tomubentkilias
andauthored
#554: Fixed bucketfs ports (#555)
fixes #554 --------- Co-authored-by: Torsten Kilias <[email protected]>
1 parent b9d4619 commit 7a67dcb

File tree

7 files changed

+49
-13
lines changed

7 files changed

+49
-13
lines changed

doc/changes/changelog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Changes
22

33
* [unreleased](unreleased.md)
4+
* [4.4.1](changes_4.4.1.md)
45
* [4.4.0](changes_4.4.0.md)
56
* [4.3.0](changes_4.3.0.md)
67
* [4.2.0](changes_4.2.0.md)
@@ -70,6 +71,7 @@ changes_0.3.0
7071
changes_0.2.0
7172
changes_0.1.0
7273
unreleased
74+
changes_4.4.1
7375
changes_4.4.0
7476
changes_4.3.0
7577
changes_4.2.0

doc/changes/changes_4.4.1.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# 4.4.1 - 2025-11-12
2+
3+
This hotfix release fixes a bug with the BucketFS ports, in which the wrong Http port for the deprecated `bucketfs` property was returned.
4+
5+
## Bugs
6+
7+
- 542: Removed Publishing Docker image from workflow
8+
- #554: Fixed bucketfs ports

doc/changes/unreleased.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1 @@
11
# Unreleased
2-
3-
## Bugs
4-
- 542: Removed Publishing Docker image from workflow

exasol_integration_test_docker_environment/lib/test_environment/ports.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import logging
22
import socket
3+
import warnings
34
from collections.abc import Generator
45
from contextlib import ExitStack
56
from typing import (
@@ -81,27 +82,27 @@ def __init__(
8182

8283
@property
8384
def bucketfs(self) -> int:
84-
logging.warn(
85+
warnings.warn(
8586
f"Property Ports.bucketfs is deprecated, use Ports.bucketfs_http instead.",
8687
DeprecationWarning,
8788
)
88-
return self._bucketfs_https
89+
return self._bucketfs_http
8990

9091
@bucketfs.setter
9192
def bucketfs(self, value: int) -> None:
92-
logging.warn(
93+
warnings.warn(
9394
f"Property Ports.bucketfs is deprecated, use Ports.bucketfs_http instead.",
9495
DeprecationWarning,
9596
)
96-
self._bucketfs_https = value
97+
self._bucketfs_http = value
9798

9899
@property
99100
def bucketfs_http(self) -> int:
100101
return self._bucketfs_http
101102

102103
@bucketfs_http.setter
103104
def bucketfs_http(self, value: int) -> None:
104-
logging.warn(
105+
warnings.warn(
105106
f"Setting values of class Ports after instantiation is deprecated.",
106107
DeprecationWarning,
107108
)
@@ -113,7 +114,7 @@ def bucketfs_https(self) -> int:
113114

114115
@bucketfs_https.setter
115116
def bucketfs_https(self, value: int) -> None:
116-
logging.warn(
117+
warnings.warn(
117118
f"Setting values of class Ports after instantiation is deprecated.",
118119
DeprecationWarning,
119120
)
@@ -125,7 +126,7 @@ def database(self) -> int:
125126

126127
@database.setter
127128
def database(self, value: int) -> None:
128-
logging.warn(
129+
warnings.warn(
129130
f"Setting values of class Ports after instantiation is deprecated.",
130131
DeprecationWarning,
131132
)
@@ -137,7 +138,7 @@ def ssh(self) -> Optional[int]:
137138

138139
@ssh.setter
139140
def ssh(self, value: Optional[int]) -> None:
140-
logging.warn(
141+
warnings.warn(
141142
f"Setting values of class Ports after instantiation is deprecated.",
142143
DeprecationWarning,
143144
)

exasol_integration_test_docker_environment/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@
1010

1111
MAJOR = 4
1212
MINOR = 4
13-
PATCH = 0
13+
PATCH = 1
1414
VERSION = f"{MAJOR}.{MINOR}.{PATCH}"
1515
__version__ = VERSION

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "exasol-integration-test-docker-environment"
3-
version = "4.4.0"
3+
version = "4.4.1"
44
description = "Integration Test Docker Environment for Exasol"
55
authors = [
66
{name="Torsten Kilias", email="[email protected]"},

test/unit/test_ports.py

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
from exasol_integration_test_docker_environment.lib.test_environment.ports import Ports
2+
3+
4+
def test_forward_ports():
5+
p = Ports.forward
6+
assert p.database == 8563
7+
assert p.bucketfs == 2580
8+
assert p.bucketfs_http == 2580
9+
assert p.ssh == 20002
10+
assert p.bucketfs_https == 2581
11+
12+
13+
def test_default_ports():
14+
p = Ports.default_ports
15+
assert p.database == 8563
16+
assert p.bucketfs == 2580
17+
assert p.bucketfs_http == 2580
18+
assert p.ssh == 22
19+
assert p.bucketfs_https == 2581
20+
21+
22+
def test_external_ports():
23+
p = Ports.external
24+
assert p.database == 8563
25+
assert p.bucketfs == 2580
26+
assert p.bucketfs_http == 2580
27+
assert p.ssh is None
28+
assert p.bucketfs_https == 2581

0 commit comments

Comments
 (0)