fb_apt: ensure keys are properly maintained #340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent rewrite to handle updated key formats has a slight corner-case problem. If the destination of the key gets deleted for any reason, Chef won't notice until the source is updated. This fixes that - idempotently, of course. Signed-off-by: Phil Dibowitz <[email protected]>
jaymzh
requested review from
dafyddcrosby,
davide125 and
joshuamiller01
as code owners
|
@michel-slm has imported this pull request. If you are a Meta employee, you can view this in D83875538. |
Contributor
|
This pull request has been merged in ee2fb22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent rewrite to handle updated key formats has a slight
corner-case problem.
If the destination of the key gets deleted for any reason, Chef won't
notice until the source is updated. This fixes that - idempotently, of
course.
Signed-off-by: Phil Dibowitz [email protected]