Merge pull request #467 from factorial-io/next

Version 0.2.0

Author: stmh

.beads/.gitignore

@@ -0,0 +1,23 @@
+# SQLite databases
+*.db
+*.db-journal
+*.db-wal
+*.db-shm
+
+# Daemon runtime files
+daemon.lock
+daemon.log
+daemon.pid
+bd.sock
+
+# Legacy database files
+db.sqlite
+bd.db
+
+# Keep JSONL exports and config (source of truth for git)
+!*.jsonl
+!metadata.json
+!config.json
+
+minibeads.lock
+command_history.log

.beads/config-minibeads.yaml

@@ -0,0 +1,8 @@
+# Minibeads-specific configuration options
+# This file contains options that are NOT compatible with upstream bd
+
+# Use hash-based issue IDs instead of sequential numbers
+# When true, issues are named like: prefix-a1b2c3 (based on content hash)
+# When false, issues are named like: prefix-1, prefix-2, ... (sequential)
+# Default: false
+mb-hash-ids: true

.beads/config.yaml

@@ -0,0 +1 @@
+issue-prefix: scotty

.beads/issues/scotty-01528.md

@@ -0,0 +1,26 @@
+---
+title: Write integration tests for domain assignments
+status: closed
+priority: 2
+issue_type: task
+labels:
+- authorization
+- enhancement
+- testing
+created_at: 2025-11-08T17:23:53.043535+00:00
+updated_at: 2025-11-24T20:17:25.558374+00:00
+closed_at: 2025-11-09T00:11:30.175622+00:00
+---
+
+# Description
+
+Create scotty/tests/authorization_domain_test.rs.
+
+Test scenarios:
+- Load config with domain assignments
+- Mock OAuth users with various email domains
+- Verify permission resolution (exact match, domain match, no match)
+- Test API endpoints (create/list domain assignments)
+- Test validation errors for invalid domain patterns
+
+Part of domain-based authorization implementation (scotty-5840d)

.beads/issues/scotty-047bf.md

@@ -0,0 +1,32 @@
+---
+title: Frontend container log viewer UI
+status: closed
+priority: 2
+issue_type: feature
+depends_on:
+  scotty-541fa: parent-child
+created_at: 2025-10-24T22:58:21.905260+00:00
+updated_at: 2025-11-24T20:17:25.571039+00:00
+closed_at: 2025-10-24T23:06:56.395577+00:00
+---
+
+# Description
+
+Add UI to view container logs in the web frontend. Backend log streaming API is complete with WebSocket support, but frontend has no log viewer component.
+
+# Design
+
+- Create log viewer component similar to unified-output.svelte
+- Add WebSocket handlers for LogLineReceived/LogStreamStarted/LogStreamEnded messages
+- Add log viewer page or modal accessible from app detail page
+- Support follow mode, timestamps, line limits
+- Reuse webSocketStore.ts infrastructure
+
+# Acceptance Criteria
+
+- Can view historical logs for any service
+- Follow mode for real-time streaming
+- Toggle timestamps on/off
+- Auto-scroll control
+- Copy logs to clipboard
+- Integration from app detail page

.beads/issues/scotty-06fec.md

@@ -0,0 +1,31 @@
+---
+title: Create metrics module with ScottyMetrics struct
+status: closed
+priority: 1
+issue_type: task
+depends_on:
+  scotty-6feea: parent-child
+  scotty-e2060: blocks
+created_at: 2025-10-24T23:28:15.721881+00:00
+updated_at: 2025-11-24T20:17:25.578481+00:00
+closed_at: 2025-10-24T23:50:03.687196+00:00
+---
+
+# Description
+
+Create scotty/src/metrics/mod.rs with ScottyMetrics struct containing all metric instruments (counters, gauges, histograms) for unified output system monitoring.
+
+# Design
+
+Create metrics module with:
+- ScottyMetrics struct with all instruments
+- init_metrics() function to set up OTLP exporter
+- Metrics for: log streams, shell sessions, WebSocket, tasks, system health
+- Uses opentelemetry::metrics API (Counter, Gauge, Histogram)
+
+# Acceptance Criteria
+
+- metrics/mod.rs created and compiles
+- ScottyMetrics struct has all planned metrics
+- init_metrics() successfully initializes MeterProvider
+- Metrics can be recorded without panics

.beads/issues/scotty-09a99.md

@@ -0,0 +1,34 @@
+---
+title: Wrap large configuration structures in Arc
+status: open
+priority: 1
+issue_type: task
+labels:
+- performance
+- refactoring
+created_at: 2025-10-26T20:21:10.606337+00:00
+updated_at: 2025-11-24T20:17:25.587875+00:00
+---
+
+# Description
+
+Settings struct contains large nested HashMaps (blueprints, registries) that get cloned unnecessarily. Wrapping them in Arc would reduce clone overhead.
+
+# Design
+
+Location: scotty-core/src/settings/apps.rs
+
+Settings contains large, rarely modified structures that are cloned when Settings is cloned.
+
+Proposed solution:
+```rust
+#[derive(Clone)]
+pub struct Apps {
+    pub root_folder: String,
+    pub blueprints: Arc<HashMap<String, AppBlueprint>>,  // Large, rarely modified
+    // ...
+}
+```
+
+Impact: Reduce Settings clone overhead
+Effort: 1-2 hours

.beads/issues/scotty-104e0.md

@@ -0,0 +1,39 @@
+---
+title: Add timeout to Docker command execution
+status: open
+priority: 1
+issue_type: task
+labels:
+- docker
+- stability
+created_at: 2025-10-26T20:21:10.406194+00:00
+updated_at: 2025-11-24T20:17:25.552589+00:00
+---
+
+# Description
+
+Docker commands currently have no timeout and could hang indefinitely if Docker daemon becomes unresponsive.
+
+# Design
+
+Location: scotty/src/docker/docker_compose.rs:88
+
+Current code:
+```rust
+let output = cmd.output()?;  // No timeout
+```
+
+Proposed solution:
+```rust
+use tokio::time::timeout;
+
+let output = timeout(
+    Duration::from_secs(300),  // 5 minute timeout
+    tokio::process::Command::new("docker-compose")
+        .args(command)
+        .output()
+).await??;
+```
+
+Impact: Prevents indefinite hangs on Docker failures
+Effort: 1-2 hours

.beads/issues/scotty-14b43.md

@@ -0,0 +1,48 @@
+---
+title: Add TaskManager metrics for task tracking
+status: closed
+priority: 2
+issue_type: task
+depends_on:
+  scotty-06fec: blocks
+created_at: 2025-10-25T00:37:07.454119+00:00
+updated_at: 2025-11-24T20:17:25.572273+00:00
+closed_at: 2025-10-25T13:29:19.632177+00:00
+---
+
+# Description
+
+Instrument TaskManager to track number of tasks, their states (running/finished/failed), durations, and success rates.
+
+# Design
+
+Add TaskManager metrics to ScottyMetrics struct:
+- tasks_total (Counter) - Total tasks created
+- tasks_by_state (Gauge) - Current tasks grouped by state labels:
+  * state="running"
+  * state="finished"
+  * state="failed"
+- task_duration_seconds (Histogram) - Task execution time
+- task_failures_total (Counter) - Failed tasks counter
+
+Implementation approach:
+1. Add metrics to scotty/src/metrics/instruments.rs
+2. Instrument scotty/src/tasks/manager.rs:
+   - add_task(): increment tasks_total, update state gauge
+   - set_task_finished(): update state gauges, record duration histogram
+   - Optional: background sampler every 30s to sync gauges with HashMap state
+
+Data sources:
+- TaskManager.processes HashMap size = total active tasks
+- TaskDetails.state: Running | Finished | Failed
+- TaskDetails.start_time + finish_time for duration calculation
+- TaskDetails.last_exit_code for success/failure tracking
+
+# Acceptance Criteria
+
+- Task metrics exported to OTLP
+- Metrics accurately reflect task states
+- Duration tracking works correctly
+- Failed vs successful tasks distinguishable
+- Dashboard panels created for task monitoring
+- No performance degradation

.beads/issues/scotty-15571.md

@@ -0,0 +1,34 @@
+---
+title: Reduce cloning overhead by wrapping AppData in Arc
+status: open
+priority: 1
+issue_type: task
+labels:
+- performance
+- refactoring
+created_at: 2025-10-26T20:21:10.340270+00:00
+updated_at: 2025-11-24T20:17:25.583693+00:00
+---
+
+# Description
+
+AppData is cloned on every access from SharedAppList. Wrapping AppData in Arc would make cloning cheap (just reference count increment) instead of copying all nested structures.
+
+# Design
+
+Location: scotty-core/src/apps/shared_app_list.rs:56-58
+
+Current code clones entire AppData structure on every get_app() call. AppData contains multiple nested structures (containers, services, settings) making clones expensive.
+
+Proposed solution:
+```rust
+pub type SharedAppData = Arc<AppData>;
+
+pub async fn get_app(&self, app_name: &str) -> Option<SharedAppData> {
+    let t = self.apps.read().await;
+    t.get(app_name).map(Arc::clone)  // Only clones Arc, not data
+}
+```
+
+Impact: Major performance improvement for app data access paths
+Effort: 2-4 hours