Skip to content

"Nested" Fancybox instance ignores "inline" type, using "clone" instead. #670

@max-novikov

Description

@max-novikov

Describe the bug

While trying to open another Fancybox, based on div from html loaded through ajax fancybox, for some reason "inline" type is ignored, and new instance is created as clone. Note that this was not the issue with the v4.

Reproduction

  1. Open some html through Fancybox ajax type. Html in question should contain an element with id attribute and display: none as style.
  2. Programmatically open another Fancybox with src set to the element from step 1 and inline as type.
  3. Instead of showing div in question, Fancybox creates a clone.

test.html attached
test.html.txt
Code to run:
Fancybox.show([{'src': 'test.html','type': 'ajax'}]);
Fancybox.show([{'src': '#sample','type': 'inline'}]);

Additional context

I've tried to upgrade Fancybox from v4 to v5 on my app, and while everything else works after some options rearrangements, the problem described above drives me nuts, as now I need to rewrite lots of markup to escape double-ids.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions