Skip to content

Commit 1f1159f

Browse files
committed
Handle looseversion errors
1 parent f5c7ee6 commit 1f1159f

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
VERSION ?= 0.4.3
1+
VERSION ?= 0.4.4
22
CACHE ?= --no-cache=1
33
FULLVERSION ?= ${VERSION}
44
archs ?= arm32v7 amd64 i386 arm64v8 arm32v6

github_release_notifier/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
"""
44

55
__all__ = ['parser', 'webhook', 'notifier']
6-
__version__ = '0.4.3'
6+
__version__ = '0.4.4'

github_release_notifier/notifier.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,11 @@ def run(file: str = __DEFAULT_FILE__) -> dict:
3838
for entry in parse(package):
3939
try:
4040
condition = version_compare(str(entry['version']), str(get_version(package))) > 0
41-
except ValueError as e:
42-
condition = LooseVersion(str(entry['version'])) > LooseVersion(str(get_version(package)))
41+
except e:
42+
try:
43+
condition = LooseVersion(str(entry['version'])) > LooseVersion(str(get_version(package)))
44+
except e:
45+
condition = False
4346
if condition:
4447
database = _get_database(file)
4548
database[package] = entry['version']

github_release_notifier/parser.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ def parse(package: str) -> List[dict]:
2626
if 'content' in item and item['content'][0] is not None and 'value' in item['content'][0]:
2727
current_dict['content'] = item['content'][0]['value']
2828
if (
29-
'media_thumbnail' in item and
30-
item['media_thumbnail'][0] is not None
31-
and 'url' in item['media_thumbnail'][0]
29+
'media_thumbnail' in item and
30+
item['media_thumbnail'][0] is not None
31+
and 'url' in item['media_thumbnail'][0]
3232
):
3333
current_dict['media'] = item['media_thumbnail'][0]['url']
3434
entries.append(current_dict)

0 commit comments

Comments
 (0)