-
Notifications
You must be signed in to change notification settings - Fork 3
Clarify generators.yml dual purpose: API declaration and code generation #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify generators.yml dual purpose: API declaration and code generation #1902
Conversation
- Update OpenAPI and gRPC generators.yml reference pages to mention both SDKs and documentation - Add clarifying notes explaining generators.yml serves two roles: declaring APIs and configuring code generation - Update generators-yml-project-structure.mdx snippet to clarify dual purpose - Add note to docs product generate-api-ref.mdx explaining APIs must be declared in generators.yml - Update API definitions project-structure.mdx comment for consistency - Fix Vale style issues (capitalize API Reference, use contractions) Addresses user feedback that generators.yml appeared to be only for SDK generation, when it also declares APIs that can be rendered in documentation via docs.yml. Co-Authored-By: Devin Logan <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
| </Tab> | ||
| <Tab title="OpenAPI (API Reference + SDKs)"> | ||
| To generate SDKs in addition to API Reference docs, add a `groups` section below your `api.specs`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [vale] reported by reviewdog 🐶
[Microsoft.Wordiness] Consider using 'also' instead of 'in addition'.
| </Tab> | ||
| <Tab title="Fern Definition"> | ||
| For Fern Definition, the `api` section is not needed. Fern auto-detects your API from the `definition/` directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Microsoft.Contractions] Use 'isn't' instead of 'is not'.
Clarify generators.yml dual purpose: API declaration and code generation
Summary
Addresses user feedback that documentation made it seem like
generators.ymlis only used for SDK generation, when in fact it also declares which APIs your project contains and those APIs can be rendered in documentation viadocs.yml.Changes made:
generators-yml-project-structure.mdxto clarify both rolesReview & Testing Checklist for Human
generators-yml-project-structure.mdxsnippet reads well when included in the API definitions project-structure page (line 35)Notes
Session: https://app.devin.ai/sessions/90f2c2014224469ab6c9166fc254b21e
Requested by: Devin Logan ([email protected]) / @devalog