-
Notifications
You must be signed in to change notification settings - Fork 14
Update documentation links to use full URLs #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation file updated to replace relative navigation links with absolute HTTPS URLs. Five "Next Steps" links in the index page now point to fully-qualified external URLs instead of local relative paths, maintaining consistency with the deployed documentation site structure. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Comment |
Summary of ChangesHello @YiyanZhai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness and clarity of the project's documentation by converting all internal relative links to full, absolute URLs. This change ensures that documentation links function correctly regardless of the viewing context, improving user experience and maintainability. Additionally, an outdated or unnecessary API reference link was removed. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates relative documentation links in docs/index.mdx to use full URLs, which is a good improvement for link stability. However, it appears that the link to the API Reference was accidentally removed during this process. I've suggested restoring it.
| - Get Started: https://bench.flashinfer.ai/docs/start/quick_start | ||
| - Installation: https://bench.flashinfer.ai/docs/start/installation | ||
| - Schema (FlashInfer Trace): https://bench.flashinfer.ai/docs/flashinfer_trace/flashinfer_trace | ||
| - Tutorials: https://bench.flashinfer.ai/docs/tutorials/bring_your_own_kernel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating the links to use full URLs, the link to the API Reference was removed. If this was unintentional, it should be restored to ensure users have access to this important documentation section.
- Get Started: https://bench.flashinfer.ai/docs/start/quick_start
- Installation: https://bench.flashinfer.ai/docs/start/installation
- Schema (FlashInfer Trace): https://bench.flashinfer.ai/docs/flashinfer_trace/flashinfer_trace
- Tutorials: https://bench.flashinfer.ai/docs/tutorials/bring_your_own_kernel
- API Reference: https://bench.flashinfer.ai/docs/api/reference
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
Ubospica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use parsable and relative link ?
Summary by CodeRabbit