Skip to content

Conversation

@Ubospica
Copy link
Collaborator

@Ubospica Ubospica commented Oct 21, 2025

Summary by CodeRabbit

  • Documentation
    • Updated README code example to demonstrate importing the library using an alias and showing the library version.
    • Added a Bosch collaborator badge to the Collaborators section under Get Started.

Copilot AI review requested due to automatic review settings October 21, 2025 22:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README to alias the flashinfer_bench import as fib and adds Bosch as a collaborator.

  • Adds import alias fib for flashinfer_bench in the installation example
  • Adds Bosch logo to the collaborators section

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Ubospica, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the README.md by introducing a more convenient alias for importing the flashinfer_bench library in Python examples. Additionally, it updates the list of project collaborators to include Bosch, reflecting an expanded network of partnerships.

Highlights

  • Python Import Alias: The README.md now suggests importing flashinfer_bench with the alias fib in Python code examples, promoting more concise usage.
  • New Collaborator Added: Bosch has been added to the list of collaborators in the README.md file, acknowledging their partnership.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Updated README.md: usage example now imports flashinfer_bench as fib and prints fib.__version__; added a Bosch collaborator badge to the Collaborators section.

Changes

Cohort / File(s) Summary
Documentation Updates
README.md
Changed code example to import flashinfer_bench as fib and print fib.__version__; added Bosch collaborator badge/link in Collaborators section

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 I hopped through the README, crisp and spry,
I nudged an alias, then gave a try,
A Bosch badge gleamed where collaborators meet,
Tiny changes, tidy and neat. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Alias flashinfer_bench as fib in README" accurately describes one of the key changes in the PR: updating the README usage example to import flashinfer_bench with the fib alias. The title is clear, concise, and directly related to a real and significant part of the changeset. While the PR also includes an additional change to add a Bosch logo/link entry to the Collaborators section, the title appropriately focuses on the primary usage example update, which is a meaningful aspect of the documentation changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 168cfb4 and a2048dd.

📒 Files selected for processing (1)
  • README.md (2 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two changes to the README.md file. First, it adds fib as a recommended alias for flashinfer_bench. Second, it adds Bosch to the list of collaborators. My review focuses on improving the clarity of the documentation. I've suggested adding a usage example for the new fib alias to make the README more helpful for new users.


```python
import flashinfer_bench
import flashinfer_bench as fib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While aliasing flashinfer_bench to fib is a good practice for brevity, the alias is not used in any example within this README. To make this initial example more illustrative and provide a more complete 'get started' experience, consider adding a small code snippet that demonstrates the usage of the fib alias. For example, you could show how to access the version number.

Suggested change
import flashinfer_bench as fib
import flashinfer_bench as fib
# Get the version of flashinfer_bench
print(fib.__version__)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6566371 and 168cfb4.

📒 Files selected for processing (1)
  • README.md (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md

56-56: Images should have alternate text (alt text)

(MD045, no-alt-text)

🔇 Additional comments (1)
README.md (1)

29-29: Import alias aligns with PR objective.

The change to alias flashinfer_bench as fib is a clean, straightforward update that matches the stated PR goal and improves brevity in usage examples.

&emsp;
[<img src="https://raw.githubusercontent.com/mlc-ai/XGrammar-web-assets/refs/heads/main/repo/vllm.png" height=50/>](https://github.com/vllm-project/vllm)
&emsp;
[<img src="https://raw.githubusercontent.com/mlc-ai/XGrammar-web-assets/refs/heads/main/repo/bosch.svg" height=50/>](https://www.bosch.com/)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add alt text to the Bosch logo image.

The image element is missing the alt attribute, which is required for accessibility and Markdown linting compliance.

Apply this diff to add alt text:

-[<img src="https://raw.githubusercontent.com/mlc-ai/XGrammar-web-assets/refs/heads/main/repo/bosch.svg" height=50/>](https://www.bosch.com/)
+[<img src="https://raw.githubusercontent.com/mlc-ai/XGrammar-web-assets/refs/heads/main/repo/bosch.svg" alt="Bosch" height=50/>](https://www.bosch.com/)
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

56-56: Images should have alternate text (alt text)

(MD045, no-alt-text)

🤖 Prompt for AI Agents
In README.md around line 56, the Bosch logo image tag is missing an alt
attribute; update the Markdown image HTML to include a descriptive alt text (for
example alt="Bosch logo") so the <img> element becomes accessible and
linter-compliant, keeping the existing src, link, and height unchanged.

@Ubospica Ubospica merged commit e780dd9 into main Oct 21, 2025
1 of 6 checks passed
@Ubospica Ubospica deleted the docs-Add-bosch-and-update-readme branch October 21, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants