Audio dispose fix (#5893)

* Add resource cleanup in audio and component classes

Dispose of the audio player in AudioService and clear hooks in Component on unmount to ensure proper resource management and prevent potential memory leaks.

* Refactor flashlight service to remove custom exceptions

Removed custom exception classes and error handling from the flet-flashlight Python and Dart implementations. The Flashlight service methods now directly invoke platform methods without raising or returning custom errors. Updated example usage and cleaned up related imports and documentation.

* Rename Flashlight methods to 'on' and 'off'

Changed method names from 'turn_on' and 'turn_off' to 'on' and 'off' in the Flashlight class and updated example usage accordingly for consistency and brevity.

* Await clipboard setData operation

Added 'await' to Clipboard.setData in ClipboardService to ensure the operation completes before proceeding. This improves reliability when setting clipboard data asynchronously.

* Replace ElevatedButton with Button in example

Updated the flashlight example to use ft.Button instead of ft.ElevatedButton for consistency or UI preference.

* Remove Flashlight exception docs and nav entries

Deleted documentation files for Flashlight exception classes and removed their references from the mkdocs navigation and the index page. This streamlines the documentation by eliminating detailed exception class pages for Flashlight.

Author: FeodorFitsner

packages/flet/lib/src/services/clipboard.dart

@@ -22,7 +22,7 @@ class ClipboardService extends FletService {
     debugPrint("ClipboardService.$name($args)");
     switch (name) {
       case "set":
-        Clipboard.setData(ClipboardData(text: args["data"]));
+        await Clipboard.setData(ClipboardData(text: args["data"]));
       case "get":
         var data = await Clipboard.getData(Clipboard.kTextPlain);
         return data?.text;

sdk/python/examples/services/audio/declarative_1.py

@@ -13,7 +13,7 @@ def App():
 
     audio, _ = ft.use_state(
         lambda: fta.Audio(
-            src="https://luan.xyz/files/audio/ambient_c_motion.mp3",
+            src="https://github.com/flet-dev/media/raw/refs/heads/main/sounds/sweet-life-luxury-chill-438146.mp3",
             autoplay=False,
             on_duration_change=lambda e: set_duration(e.duration.in_milliseconds),
             on_position_change=lambda e: set_position(e.position),

sdk/python/examples/services/flashlight/example_1.py

@@ -3,11 +3,16 @@
 
 
 def main(page: ft.Page):
-    async def toggle_flashlight():
-        flashlight = ffl.Flashlight()
-        await flashlight.toggle()
+    async def turn_on_flashlight():
+        await ffl.Flashlight().on()
 
-    page.add(ft.TextButton("toggle", on_click=toggle_flashlight))
+    async def turn_off_flashlight():
+        await ffl.Flashlight().off()
+
+    page.add(
+        ft.Button("Turn On Flashlight", on_click=turn_on_flashlight),
+        ft.Button("Turn Off Flashlight", on_click=turn_off_flashlight),
+    )
 
 
 ft.run(main)

sdk/python/packages/flet-audio/src/flutter/flet_audio/lib/src/audio.dart

@@ -178,6 +178,7 @@ class AudioService extends FletService {
     _onStateChangedSubscription?.cancel();
     _onPositionChangedSubscription?.cancel();
     _onSeekCompleteSubscription?.cancel();
+    player.dispose();
     super.dispose();
   }
 }

sdk/python/packages/flet-flashlight/src/flet_flashlight/__init__.py

@@ -1,21 +1,5 @@
-from .exceptions import (
-    FlashlightDisableException,
-    FlashlightDisableExistentUserException,
-    FlashlightDisableNotAvailableException,
-    FlashlightEnableException,
-    FlashlightEnableExistentUserException,
-    FlashlightEnableNotAvailableException,
-    FlashlightException,
-)
 from .flashlight import Flashlight
 
 __all__ = [
     "Flashlight",
-    "FlashlightDisableException",
-    "FlashlightDisableExistentUserException",
-    "FlashlightDisableNotAvailableException",
-    "FlashlightEnableException",
-    "FlashlightEnableExistentUserException",
-    "FlashlightEnableNotAvailableException",
-    "FlashlightException",
 ]

sdk/python/packages/flet-flashlight/src/flet_flashlight/exceptions.py

@@ -1,17 +1,5 @@
-from typing import Optional
-
 import flet as ft
 
-from .exceptions import (
-    FlashlightDisableException,
-    FlashlightDisableExistentUserException,
-    FlashlightDisableNotAvailableException,
-    FlashlightEnableException,
-    FlashlightEnableExistentUserException,
-    FlashlightEnableNotAvailableException,
-    FlashlightException,
-)
-
 __all__ = ["Flashlight"]
 
 
@@ -21,69 +9,20 @@ class Flashlight(ft.Service):
     A control to use FlashLight. Works on iOS and Android.
     """
 
-    on = False
-    """
-    Whether the flashlight is currently turned on.
-    """
-
-    on_error: Optional[ft.ControlEventHandler["Flashlight"]] = None
-    """
-    Fires when an error occurs.
-
-    The [`data`][flet.Event.data] property of the event handler argument
-    contains information on the error.
-    """
-
-    async def turn_on(self):
+    async def on(self):
         """
         Turns the flashlight on.
         """
-        r = await self._invoke_method("on")
-        if r is True:
-            self.on = True
-        else:  # error occured
-            error_type = r.get("error_type")
-            error_msg = r.get("error_msg")
-            if error_type == "EnableTorchExistentUserException":
-                raise FlashlightEnableExistentUserException(error_msg)
-            elif error_type == "EnableTorchNotAvailableException":
-                raise FlashlightEnableNotAvailableException(error_msg)
-            else:
-                raise FlashlightEnableException(error_msg)
+        await self._invoke_method("on")
 
-    async def turn_off(self):
+    async def off(self):
         """
         Turns the flashlight off.
         """
-        r = await self._invoke_method("off")
-        if r is True:
-            self.on = False
-        else:  # error occured
-            error_type = r.get("error_type")
-            error_msg = r.get("error_msg")
-            if error_type == "DisableTorchExistentUserException":
-                raise FlashlightDisableExistentUserException(error_msg)
-            elif error_type == "DisableTorchNotAvailableException":
-                raise FlashlightDisableNotAvailableException(error_msg)
-            else:
-                raise FlashlightDisableException(error_msg)
-
-    async def toggle(self):
-        """
-        Toggles the flashlight on and off.
-        """
-        if self.on:
-            await self.turn_off()
-        else:
-            await self.turn_on()
+        await self._invoke_method("off")
 
     async def is_available(self):
         """
         Checks if the flashlight is available on the device.
         """
-        r = await self._invoke_method("is_available")
-        if isinstance(r, bool):
-            return r
-        else:  # error occured
-            error_msg = r.get("error_msg")
-            raise FlashlightException(error_msg)
+        return await self._invoke_method("is_available")

sdk/python/packages/flet-flashlight/src/flet_flashlight/flashlight.py

@@ -15,74 +15,13 @@ class FlashlightControl extends FletService {
   Future<dynamic> _invokeMethod(String name, dynamic args) async {
     debugPrint("Flashlight.$name($args)");
     if (isMobilePlatform()) {
-      Map<String, String?>? errorInfo;
       switch (name) {
         case "on":
-          try {
-            await TorchLight.enableTorch();
-            return true;
-          } catch (e) {
-            if (e is EnableTorchExistentUserException) {
-              errorInfo = {
-                "error_type": "EnableTorchExistentUserException",
-                "error_msg": e.message
-              };
-            } else if (e is EnableTorchNotAvailableException) {
-              errorInfo = {
-                "error_type": "EnableTorchNotAvailableException",
-                "error_msg": e.message
-              };
-            } else {
-              errorInfo = {
-                "error_type": "EnableTorchException",
-                "error_msg": (e as EnableTorchException).message
-              };
-            }
-            control.triggerEvent("error", errorInfo);
-            debugPrint(
-                "Error enabling Flashlight: ${errorInfo["error_type"]}(${errorInfo["error_msg"]})");
-            return errorInfo;
-          }
+          await TorchLight.enableTorch();
         case "off":
-          try {
-            await TorchLight.disableTorch();
-            return true;
-          } catch (e) {
-            if (e is DisableTorchExistentUserException) {
-              errorInfo = {
-                "error_type": "DisableTorchExistentUserException",
-                "error_msg": e.message
-              };
-            } else if (e is DisableTorchNotAvailableException) {
-              errorInfo = {
-                "error_type": "DisableTorchNotAvailableException",
-                "error_msg": e.message
-              };
-            } else {
-              errorInfo = {
-                "error_type": "DisableTorchException",
-                "error_msg": (e as DisableTorchException).message
-              };
-            }
-            control.triggerEvent("error", errorInfo);
-            debugPrint(
-                "Error disabling Flashlight: ${errorInfo["error_type"]}(${errorInfo["error_msg"]})");
-            return errorInfo;
-          }
+          await TorchLight.disableTorch();
         case "is_available":
-          try {
-            final available = await TorchLight.isTorchAvailable();
-            return available;
-          } on EnableTorchException catch (e) {
-            errorInfo = {
-              "error_type": "EnableTorchException",
-              "error_msg": e.message
-            };
-            control.triggerEvent("error", errorInfo);
-            debugPrint(
-                "Error checking Flashlight availability: EnableTorchException(${e.message})");
-            return errorInfo;
-          }
+          return await TorchLight.isTorchAvailable();
         default:
           throw Exception("Unknown Flashlight method: $name");
       }