Respect base_url config for <base>
#1534
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies PSR-4 definition.
More type safe and allows to introduce extra validations.
0c8e133 introduced `<base>` tag into the template, which was based on directory of `SCRIPT_NAME`. This configurations where selfoss was behind a reverse proxy mapping it into a subdirectory, using `base_url` config.
Use early return to make the code slightly more legible. This is also a prerequisite for overriding just the path when non-absolute URL is configured.
This is required by both uses: - RSS controller: RSS feeds are supposed to contain absolute paths - Session: Cookies depend on URI scheme and host If `base_url` was configured to an absolute path reference, not an absolute URI, those would fail.
✅ Deploy Preview for selfoss ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1533
Fixes: #1525