Chore: all components now use the same favicon with different ones only for debug mode (#1120)

Saksham-Sirohi · mariobehling · web-flow · commit 40ed228acba6 · 2025-10-27T20:58:11.000+01:00
* all components now use the same favicon with different for debug mode

* Update app/eventyay/webapp/src/preloader.js

---------

Co-authored-by: Mario Behling &lt;mb@mariobehling.de&gt;
diff --git a/app/eventyay/base/templates/error.html b/app/eventyay/base/templates/error.html
@@ -10,7 +10,7 @@
     {% endcompress %}
     <meta name="viewport" content="width=device-width, initial-scale=1">
     <meta charset="utf-8">
-    <link rel="icon" href="{% static "pretixbase/img/favicon.ico" %}">
+    <link rel="icon" href="{% static "common/img/icons/favicon.ico" %}">
 </head>
 <body>
 <div class="container">
diff --git a/app/eventyay/control/templates/pretixcontrol/admin/pages/base.html b/app/eventyay/control/templates/pretixcontrol/admin/pages/base.html
@@ -13,9 +13,9 @@
         <link type="text/css" rel="stylesheet" href="{% static "pages/css/quill-edit.css" %}">
     {% endcompress %}
     {% if development_warning or debug_warning %}
-        <link rel="shortcut icon" href="{% static "pretixbase/img/favicon-debug.ico" %}">
+        <link rel="shortcut icon" href="{% static "common/img/icons/favicon_debug.ico" %}">
     {% else %}
-        <link rel="shortcut icon" href="{% static "pretixbase/img/favicon.ico" %}">
+        <link rel="shortcut icon" href="{% static "common/img/icons/favicon.ico" %}">
         <link rel="icon" type="image/png" sizes="32x32" href="{% static "pretixbase/img/icons/favicon-32x32.png" %}">
         <link rel="icon" type="image/png" sizes="194x194" href="{% static "pretixbase/img/icons/favicon-194x194.png" %}">
         <link rel="icon" type="image/png" sizes="16x16" href="{% static "pretixbase/img/icons/favicon-16x16.png" %}">
diff --git a/app/eventyay/control/templates/pretixcontrol/base.html b/app/eventyay/control/templates/pretixcontrol/base.html
@@ -67,9 +67,9 @@
 
         <meta name="viewport" content="width=device-width, initial-scale=1">
         {% if development_warning or debug_warning %}
-            <link rel="shortcut icon" href="{% static "pretixbase/img/favicon-debug.ico" %}">
+            <link rel="shortcut icon" href="{% static "common/img/icons/favicon_debug.ico" %}">
         {% else %}
-            <link rel="shortcut icon" href="{% static "pretixbase/img/favicon.ico" %}">
+            <link rel="shortcut icon" href="{% static "common/img/icons/favicon.ico" %}">
             <link rel="icon" type="image/png" sizes="32x32" href="{% static "pretixbase/img/icons/favicon-32x32.png" %}">
             <link rel="icon" type="image/png" sizes="194x194" href="{% static "pretixbase/img/icons/favicon-194x194.png" %}">
             <link rel="icon" type="image/png" sizes="16x16" href="{% static "pretixbase/img/icons/favicon-16x16.png" %}">
diff --git a/app/eventyay/eventyay_common/templates/eventyay_common/auth/base.html b/app/eventyay/eventyay_common/templates/eventyay_common/auth/base.html
@@ -17,9 +17,9 @@
     <meta name="viewport" content="width=device-width, initial-scale=1">
 
     {% if development_warning or debug_warning %}
-        <link rel="shortcut icon" href="{% static "pretixbase/img/favicon-debug.ico" %}">
+        <link rel="shortcut icon" href="{% static "common/img/icons/favicon_debug.ico" %}">
     {% else %}
-        <link rel="shortcut icon" href="{% static "pretixbase/img/favicon.ico" %}">
+        <link rel="shortcut icon" href="{% static "common/img/icons/favicon.ico" %}">
         <link rel="icon" type="image/png" sizes="32x32" href="{% static "pretixbase/img/icons/favicon-32x32.png" %}">
         <link rel="icon" type="image/png" sizes="194x194" href="{% static "pretixbase/img/icons/favicon-194x194.png" %}">
         <link rel="icon" type="image/png" sizes="16x16" href="{% static "pretixbase/img/icons/favicon-16x16.png" %}">
diff --git a/app/eventyay/eventyay_common/templates/eventyay_common/base.html b/app/eventyay/eventyay_common/templates/eventyay_common/base.html
@@ -68,9 +68,9 @@
 
         <meta name="viewport" content="width=device-width, initial-scale=1">
         {% if development_warning or debug_warning %}
-            <link rel="shortcut icon" href="{% static "pretixbase/img/favicon-debug.ico" %}">
+            <link rel="shortcut icon" href="{% static "common/img/icons/favicon_debug.ico" %}">
         {% else %}
-            <link rel="shortcut icon" href="{% static "pretixbase/img/favicon.ico" %}">
+            <link rel="shortcut icon" href="{% static "common/img/icons/favicon.ico" %}">
             <link rel="icon" type="image/png" sizes="32x32" href="{% static "pretixbase/img/icons/favicon-32x32.png" %}">
             <link rel="icon" type="image/png" sizes="194x194" href="{% static "pretixbase/img/icons/favicon-194x194.png" %}">
             <link rel="icon" type="image/png" sizes="16x16" href="{% static "pretixbase/img/icons/favicon-16x16.png" %}">
diff --git a/app/eventyay/plugins/webcheckin/templates/pretixplugins/webcheckin/index.html b/app/eventyay/plugins/webcheckin/templates/pretixplugins/webcheckin/index.html
@@ -18,7 +18,7 @@
     {% endif %}
     {{ html_head|safe }}
     <meta name="viewport" content="width=device-width, initial-scale=1">
-    <link rel="icon" href="{% static "pretixbase/img/favicon.ico" %}">
+    <link rel="icon" href="{% static "common/img/icons/favicon.ico" %}">
 </head>
 <body data-datetimeformat="{{ js_datetime_format }}" data-timeformat="{{ js_time_format }}"
       data-dateformat="{{ js_date_format }}" data-datetimelocale="{{ js_locale }}"
diff --git a/app/eventyay/presale/templates/pretixpresale/base.html b/app/eventyay/presale/templates/pretixpresale/base.html
@@ -31,10 +31,10 @@
         <link rel="icon" type="image/png" sizes="194x194" href="{{ settings.favicon|thumb:'194x194^' }}">
         <link rel="icon" type="image/png" sizes="16x16" href="{{ settings.favicon|thumb:'16x16^' }}">
     {% elif development_warning or debug_warning %}
-        <link rel="shortcut icon" href="{% static "pretixbase/img/favicon-debug.ico" %}">
+        <link rel="shortcut icon" href="{% static "common/img/icons/favicon_debug.ico" %}">
     {% else %}
-        <link rel="icon" href="{% static "pretixbase/img/favicon.ico" %}">
-        <link rel="shortcut icon" href="{% static "pretixbase/img/favicon.ico" %}">
+        <link rel="icon" href="{% static "common/img/icons/favicon.ico" %}">
+        <link rel="shortcut icon" href="{% static "common/img/icons/favicon.ico" %}">
         <link rel="icon" type="image/png" sizes="32x32" href="{% static "pretixbase/img/icons/favicon-32x32.png" %}">
         <link rel="icon" type="image/png" sizes="194x194" href="{% static "pretixbase/img/icons/favicon-194x194.png" %}">
         <link rel="icon" type="image/png" sizes="16x16" href="{% static "pretixbase/img/icons/favicon-16x16.png" %}">
diff --git a/app/eventyay/static/common/img/icons/favicon.ico b/app/eventyay/static/common/img/icons/favicon.ico
diff --git a/app/eventyay/webapp/index.html b/app/eventyay/webapp/index.html
@@ -5,7 +5,8 @@
 	<meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <meta name="mobile-web-app-capable" content="yes" />
-    <link rel="icon" href="/favicon.ico" />
+    <link rel="icon" id="favicon" href="/static/common/img/icons/favicon.ico" />
+    <link rel="shortcut icon" id="favicon-shortcut" href="/static/common/img/icons/favicon.ico" />
     <title>eventyay</title>
   </head>
   <body>
diff --git a/app/eventyay/webapp/public/favicon.ico b/app/eventyay/webapp/public/favicon.ico
diff --git a/app/eventyay/webapp/public/index.html b/app/eventyay/webapp/public/index.html
@@ -5,7 +5,8 @@
 		<meta http-equiv="X-UA-Compatible" content="IE=edge">
 		<meta name="viewport" content="width=device-width,initial-scale=1.0">
 		<meta name="apple-mobile-web-app-capable" content="yes">
-		<link rel="icon" href="<%= BASE_URL %>favicon.ico">
+		<link rel="icon" id="favicon" href="/static/common/img/icons/favicon.ico">
+		<link rel="shortcut icon" id="favicon-shortcut" href="/static/common/img/icons/favicon.ico">
 		<title><%= htmlWebpackPlugin.options.title %></title>
 	</head>
 	<body>
diff --git a/app/eventyay/webapp/src/preloader.js b/app/eventyay/webapp/src/preloader.js
@@ -1,5 +1,16 @@
 import 'styles/preloader.styl'
 
+/* global ENV_DEVELOPMENT */
+
+// Set debug favicon in development mode
+const DEBUG_FAVICON_PATH = '/static/common/img/icons/favicon_debug.ico';
+if (ENV_DEVELOPMENT) {
+	const favicon = document.getElementById('favicon')
+	const faviconShortcut = document.getElementById('favicon-shortcut')
+	if (favicon) favicon.href = DEBUG_FAVICON_PATH
+	if (faviconShortcut) faviconShortcut.href = DEBUG_FAVICON_PATH
+}
+
 const showBrowserBlock = function() {
 	document.getElementById('browser-block').style.display = 'block'
 	document.body.removeChild(document.getElementById('app'))
