Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Sep 1, 2025

This PR fixes the AD1 implementation and adds support for rudimentary ADCRYPT decryption using the cli tool adecrypt (#37, #38). Also restructured the project and tests a bit.

@Schamper Schamper self-requested a review October 15, 2025 13:47
@JSCU-CNI JSCU-CNI requested a review from Schamper October 28, 2025 14:30
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still haven't looked in much detail at the actual parsing, but these comments are quite big again. Let me know if I can be of any help resolving them.

@Schamper
Copy link
Member

Schamper commented Dec 5, 2025

I've made some changes, let me know if you agree.

@Schamper Schamper force-pushed the ad1 branch 2 times, most recently from 89e5f6c to 08365f4 Compare December 5, 2025 19:07
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 88.95349% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.44%. Comparing base (971b899) to head (f5db15a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
dissect/evidence/ad1/ad1.py 90.42% 25 Missing ⚠️
dissect/evidence/adcrypt/adcrypt.py 84.48% 9 Missing ⚠️
dissect/evidence/tools/adcrypt.py 81.25% 9 Missing ⚠️
dissect/evidence/tools/util.py 57.14% 9 Missing ⚠️
dissect/evidence/adcrypt/stream.py 88.46% 3 Missing ⚠️
dissect/evidence/ad1/stream.py 97.95% 1 Missing ⚠️
dissect/evidence/tools/asdf/repair.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   63.17%   71.44%   +8.27%     
==========================================
  Files          11       23      +12     
  Lines        1013     1387     +374     
==========================================
+ Hits          640      991     +351     
- Misses        373      396      +23     
Flag Coverage Δ
unittests 71.44% <88.95%> (+8.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Dec 8, 2025

I've made some changes, let me know if you agree.

Thank you for the applied changes, especially the ADCRYPT and stream implementations. Will take a look at the companion PR in dissect.target to make unlock work with the keychain.

@Schamper Schamper merged commit 354d252 into fox-it:main Dec 8, 2025
21 of 23 checks passed
@Schamper Schamper mentioned this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ADCRYPT Add support for AD1

2 participants