fix(logger): stop overwriting global vim.notify function

Author: frankroeder

lua/parrot/config.lua

@@ -255,7 +255,7 @@ M.hooks = nil
 
 function M.setup(opts)
   if vim.fn.has("nvim-0.10") == 0 then
-    return vim.notify("parrot.nvim requires Neovim >= 0.10", vim.log.levels.ERROR)
+    return M.logger.notify("parrot.nvim requires Neovim >= 0.10", vim.log.levels.ERROR)
   end
 
   math.randomseed(os.time())

lua/parrot/context.lua

@@ -61,7 +61,7 @@ function M.insert_contexts(msg)
         end
         content = content:gsub("\n+$", "")
         if show_hints then
-          vim.notify("Attached context " .. source_info .. ": " .. vim.fs.basename(filepath))
+          logger.notify("Attached context " .. source_info .. ": " .. vim.fs.basename(filepath))
         end
         table.insert(contexts, { content = content, filetype = ft, name = filepath })
       else
@@ -123,7 +123,7 @@ function M.insert_contexts(msg)
             local buf_lines = vim.api.nvim_buf_get_lines(buf_nr, 0, -1, false)
             local name = vim.api.nvim_buf_get_name(buf_nr)
             if show_hints then
-              vim.notify("Attached context @buffer: " .. vim.fs.basename(name))
+              logger.notify("Attached context @buffer: " .. vim.fs.basename(name))
             end
             return { content = table.concat(buf_lines, "\n"), filetype = ft, name = name }
           end)
@@ -165,7 +165,7 @@ function M.insert_contexts(msg)
                     end
                     content = content:gsub("\n+$", "")
                     if show_hints then
-                      vim.notify(
+                      logger.notify(
                         "Attached context @directory: " .. vim.fs.basename(dir_path) .. " - " .. vim.fs.basename(file)
                       )
                     end

lua/parrot/logger.lua

@@ -3,12 +3,13 @@ local M = {
   _logfile = vim.fn.stdpath("state") .. "/parrot.nvim.log",
   _max_log_lines = 10000,
   _debug_enabled = vim.env.DEBUG_PARROT ~= nil,
+  notify = vim.notify
 }
 
 -- Use pcall to safely require the notify plugin
 local notify_ok, notify = pcall(require, "notify")
 if notify_ok then
-  vim.notify = notify
+  M.notify = notify
 end
 
 -- Get stack trace information
@@ -84,9 +85,9 @@ local function write_to_logfile(msg, kind, stack_info)
 
   local success = write_file(M._logfile, limited_log .. log_entry .. "\n")
   if not success and kind ~= "Debug" then
-    -- Fallback to vim.notify if file write fails
+    -- Fallback to M.notify if file write fails
     vim.schedule(function()
-      vim.notify("Failed to write to log file: " .. M._logfile, vim.log.levels.WARN, { title = M._plugin_name })
+      M.notify("Failed to write to log file: " .. M._logfile, vim.log.levels.WARN, { title = M._plugin_name })
     end)
   end
 end
@@ -109,7 +110,7 @@ local function log(msg, kind, level, include_stack)
         msg = msg .. "\nLocation: " .. stack_info
       end
 
-      vim.notify(msg, level, notify_opts)
+      M.notify(msg, level, notify_opts)
     end)
   end
 end

tests/parrot/logger_spec.lua

@@ -3,6 +3,7 @@ local logger = require("parrot.logger")
 describe("Logger", function()
   local original_notify
   local original_schedule
+  local original_logger_notify
   local notify_calls = {}
   local schedule_calls = {}
 
@@ -13,6 +14,12 @@ describe("Logger", function()
       table.insert(notify_calls, { msg = msg, level = level, opts = opts })
     end
 
+    -- Mock logger.notify
+    original_logger_notify = logger.notify
+    logger.notify = function(msg, level, opts)
+      table.insert(notify_calls, { msg = msg, level = level, opts = opts })
+    end
+
     -- Mock vim.schedule
     original_schedule = vim.schedule
     vim.schedule = function(fn)
@@ -28,6 +35,7 @@ describe("Logger", function()
   after_each(function()
     vim.notify = original_notify
     vim.schedule = original_schedule
+    logger.notify = original_logger_notify
   end)
 
   describe("error function", function()