Button loading fix #2414
Open
Button loading fix #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bowrna
force-pushed
the
button_loading_fix
branch
from
aecf3c0 to
ad7b739
Compare
|
Please use conventional commits |
|
no, we should show the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2242
related_to: #2242
This PR has fixed the issue only for the attachment icon when sending an email, and this fix is specifically designed to show the loading progress and prevent further uploads at that time. I have raised only the partial fix as I have some questions regarding the other uploads.
@RitvikSardana In case of uploading image and video icon in reply/comment, helpdesk relies on TextEditorFixedMenu component of frappe-ui and Insert Image, InsertVideo that comes as part of it. It's not easy to directly handle this case, unlike button component where the upload, progress slots are open. How do you think it could be handled in a better way?