Replies: 2 comments 2 replies
-
|
We talked about this a bit on the call, but how do we envision that we'd get this from input? Would we have specific rules based on mode (e.g. gnomad/vcf is always genomic, hgvs gives you the type in the string, etc?) |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
I think this is a great idea — in my work translating VRS Allele to FHIR AlleleProfiles, I’ve had to extract moleculeType and residueAlphabet myself when they weren’t already present. Having this supported directly in vrs-python would definitely streamline that process and improve consistency. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I was looking through the Variation Normalizer issues and noticed we had Add moleculeType to SequenceReference (#594). The AnyVar developers recently had a discussion about molecule type, which would likely be needed for Write functions for forward and reverse transcription and translation (#146).
I think this raises the question on whether VRS-Python Translators should have some kind of annotation mode. Currently, the translate_from methods generate the minimal value object. Should we consider having an annotation mode to allow for information such as
moleculeTypeto be included in the generated VRS object?We should make sure that annotations do not make any additional policy decisions (these belong in the Variation Normalizer) and should stick with the current nomenclature's policies.
Beta Was this translation helpful? Give feedback.
All reactions