Skip to content

Conversation

@vitaly-zdanevich
Copy link
Contributor

@stkw0
Copy link
Contributor

stkw0 commented Jun 17, 2025

It's not acceptable to just make a copy-paste and expect it would be merged. You can close this PR, or look for yourself what is wrong and fix it.

@vitaly-zdanevich
Copy link
Contributor Author

@stkw0 removed <maintainer>, what else?

@vitaly-zdanevich
Copy link
Contributor Author

Fixed dependencies.

@stkw0
Copy link
Contributor

stkw0 commented Jun 18, 2025

Starting with the most formal things:

  • commit don't have the Signed-off-by tag
  • The change to the DESCRIPTION makes it more obscure to understand what is this package about
  • you just copy-pasted a pretty old version, why you didn't even cared to update it?
  • we only store the hashes for DIST entries, not EBUILD or MISC. Metadata file should be regenerated
  • Yes, the maintainer file was wrong, it is still wrong as it should have the maintainer needed comment.
  • As you might have noticed, the minimum python version was being moved to pyhon3_11
  • you clearly didn't run pkgcheck, which is supposed to be a tool to help find common mistakes
  • KEYWORDS should only list the arch that has been tested. And you probably didn't test the arm ones
  • (maybe something else I miss)

Most of it, individually, could be taken as a small slip. However, in this case it was clearly not a mistake but a total carelessness. Even worst given that you have been around for ¿years? so you were probably aware of the most basic things (so it's not because of ignorance). As a result, I think you are not competent enough and that it would be bad for the maintenance of the repository to add your ebuilds or the ones you send, unless there is a more capable person that is willing to take care of maintaining them.

I would not review or merge your PR that adds a new package from now on, and it's my opinion that you should avoid sending PR for new packages (and close the ones that add new packages).

@vitaly-zdanevich vitaly-zdanevich changed the title new package dev-python/pyicloud new package Jun 18, 2025
@vitaly-zdanevich vitaly-zdanevich force-pushed the pyicloud-add branch 2 times, most recently from 1d5a421 to d6a1393 Compare June 18, 2025 14:13
@vitaly-zdanevich
Copy link
Contributor Author

you just copy-pasted a pretty old version, why you didn't even cared to update it?

You did not check the upstream https://github.com/picklepete/pyicloud - 1.0.0 is the latest version.

@vitaly-zdanevich vitaly-zdanevich force-pushed the pyicloud-add branch 4 times, most recently from 7d810a8 to 131a1be Compare June 18, 2025 14:21
@vitaly-zdanevich
Copy link
Contributor Author

Fixed everything.

@stkw0
Copy link
Contributor

stkw0 commented Jun 18, 2025

Last version is the 2.0.1 from 4 days ago. See https://pypi.org/project/pyicloud/#history, https://github.com/timlaing/pyicloud and github.com/pypi/support/issues/5377

@vitaly-zdanevich vitaly-zdanevich force-pushed the pyicloud-add branch 2 times, most recently from 8487005 to 800430a Compare June 18, 2025 14:43
@vitaly-zdanevich
Copy link
Contributor Author

Replaced the upstream.

@vitaly-zdanevich
Copy link
Contributor Author

close the ones that add new packages

#298 is needed to fix Organicmaps #297

@MrRoy
Copy link
Contributor

MrRoy commented Jun 18, 2025

Replaced the upstream.

Not in metadata.xml

@vitaly-zdanevich vitaly-zdanevich force-pushed the pyicloud-add branch 2 times, most recently from 0c820a4 to 7102cf8 Compare June 19, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants