-
Notifications
You must be signed in to change notification settings - Fork 165
dev-python/pyicloud new package #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2c3ecb7 to
f1f0743
Compare
|
It's not acceptable to just make a copy-paste and expect it would be merged. You can close this PR, or look for yourself what is wrong and fix it. |
f1f0743 to
1aadc45
Compare
|
@stkw0 removed |
1aadc45 to
7583cb5
Compare
|
Fixed dependencies. |
|
Starting with the most formal things:
Most of it, individually, could be taken as a small slip. However, in this case it was clearly not a mistake but a total carelessness. Even worst given that you have been around for ¿years? so you were probably aware of the most basic things (so it's not because of ignorance). As a result, I think you are not competent enough and that it would be bad for the maintenance of the repository to add your ebuilds or the ones you send, unless there is a more capable person that is willing to take care of maintaining them. I would not review or merge your PR that adds a new package from now on, and it's my opinion that you should avoid sending PR for new packages (and close the ones that add new packages). |
1d5a421 to
d6a1393
Compare
You did not check the upstream https://github.com/picklepete/pyicloud - 1.0.0 is the latest version. |
7d810a8 to
131a1be
Compare
|
Fixed everything. |
|
Last version is the 2.0.1 from 4 days ago. See https://pypi.org/project/pyicloud/#history, https://github.com/timlaing/pyicloud and github.com/pypi/support/issues/5377 |
8487005 to
800430a
Compare
|
Replaced the upstream. |
Not in metadata.xml |
0c820a4 to
7102cf8
Compare
From https://github.com/onkelbeh/HomeAssistantRepository/tree/master/dev-python/pyicloud Signed-off-by: Vitaly Zdanevich <[email protected]>
7102cf8 to
8a4e60c
Compare
From https://github.com/onkelbeh/HomeAssistantRepository/tree/master/dev-python/pyicloud