Upgrade kmp and java apps to use 5.0.0-preview.3 #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phatblat
force-pushed
the
ben/kotlin-java-5.0-preview.3
branch
2 times, most recently
from
e0d95f1 to
f133c2f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Upgrades Kotlin Multiplatform and Java applications to use Ditto SDK version 5.0.0-preview.3, updating the API implementation to match the new SDK interface.
- Updated Ditto SDK version from 5.0.0-preview.1 to 5.0.0-preview.3
- Migrated from DittoIdentity-based authentication to new authentication provider pattern
- Changed API method calls to use new naming conventions (e.g.,
registerObservertoobserve,getStringtoasString)
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| kotlin-multiplatform/composeApp/build.gradle.kts | Updated Ditto dependency versions to 5.0.0-preview.3 |
| kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt | Refactored Ditto initialization to use new authentication pattern and updated API calls |
| kotlin-multiplatform/composeApp/src//kotlin/com/ditto/quickstart/ditto/DittoManager..kt | Updated platform-specific Ditto creation to use DittoFactory |
| kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/data/DittoCredentials.kt | Added new data class for Ditto credentials |
| kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/di/DittoModule.kt | Updated dependency injection to include credentials |
| kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/data/repository/DittoTaskRepository.kt | Updated API method call from registerObserver to observe |
| kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ui/TaskAddEditScreen.kt | Minor UI layout adjustment |
| kotlin-multiplatform/README.md | Updated API reference link to preview.3 version |
| java-spring/src/main/java/com/ditto/example/spring/quickstart/service/DittoService.java | Migrated to new authentication pattern and updated transport configuration |
| java-spring/src/main/java/com/ditto/example/spring/quickstart/service/DittoTaskService.java | Updated API method calls to use new naming conventions |
| java-spring/build.gradle.kts | Updated Ditto dependency versions to 5.0.0-preview.3 |
| java-spring/java-spring-maven/pom.xml | Added Maven configuration with preview.3 dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/di/DittoModule.kt
Outdated
Show resolved
Hide resolved
phatblat
force-pushed
the
ben/kotlin-java-5.0-preview.3
branch
from
f133c2f to
f7377a2
Compare
phatblat
force-pushed
the
ben/kotlin-java-5.0-preview.3
branch
5 times, most recently
from
1990e36 to
b9055f9
Compare
russhwolf
reviewed
Oct 20, 2025
russhwolf
left a comment
russhwolf
left a comment
There was a problem hiding this comment.
What's the expected status of tests? The browserstack CI failure also happens for me locally, and I have similar failures in both the Android and iOS integration tests which are not being run in CI.
Otherwise, mostly nits here.
java-server/src/main/java/com/ditto/example/spring/quickstart/service/DittoTaskService.java
Outdated
Show resolved
Hide resolved
...in-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt
Outdated
Show resolved
Hide resolved
...in-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt
Show resolved
Hide resolved
...in-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt
Show resolved
Hide resolved
...in-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt
Outdated
Show resolved
Hide resolved
russhwolf
approved these changes
Oct 20, 2025
russhwolf
left a comment
russhwolf
left a comment
There was a problem hiding this comment.
Moving to approve after in-person convo that we haven't been maintaining those tests. We should probably update them at some point but I don't want to gatekeep this PR on that.
resolves issue on iOS where a new task couldn’t be added because the button is hidden behind the keyboard
phatblat
force-pushed
the
ben/kotlin-java-5.0-preview.3
branch
from
9549e56 to
9210e42
Compare
busec0
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Java Server and Kotlin Multiplatform Quickstart apps to use Ditto
5.0.0-preview.3.Other Changes
java-spring/tojava-server/java-server/java-spring-maven/subproject for testing Maven compatibility