Tooling for copyright headers for files other than *.js
#1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
matthew-white
approved these changes
Nov 11, 2025
Member
matthew-white
left a comment
matthew-white
left a comment
There was a problem hiding this comment.
Thanks, @brontolosone!
Is there any chance I could interest you in getodk/central#1274 as well?
brontolosone
force-pushed
the
formalize-pure-sql-migrations-copyrightheaders
branch
from
33c48a7 to
9fce620
Compare
Contributor
Author
Sure! I've assigned it to myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1651
We have some .sql files in the repo that are currently missed by
lib/bin/check-file-headers.js, and have no copyright header.This changes the
lib/bin/check-file-headers.jsscript to be easily extendable to work on arbitrary file types (of languages that sport per-line comment symbols), and extends it for SQL.It's then applied it to the existing .sql migration files ✨
What has been done to verify that this works as intended?
CI
Why is this the best possible solution? Were any other approaches considered?
N/A
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
N/A
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes