Skip to content

Commit e2c8a79

Browse files
committed
Reimplement progress
1 parent c0b9e06 commit e2c8a79

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormUseCases.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,18 @@ object ServerFormUseCases {
174174
existingFile?.getMd5Hash().contentEquals(mediaFile.hash)
175175
}
176176

177+
var progress = 1
178+
177179
if (formToDownload.type != ServerFormDetails.Type.UpdatedMedia) {
178180
existingMediaFiles.forEach { (_, existingFile) ->
181+
stateListener.progressUpdate(progress++)
179182
copyFileToDirectory(existingFile, tempMediaDir)
180183
}
181184
}
182185

183186
mediaFilesToDownload.forEach { (mediaFile, existingFile) ->
187+
stateListener.progressUpdate(progress++)
188+
184189
val tempMediaFile = File(tempMediaDir, mediaFile.filename)
185190
downloadMediaFile(
186191
formSource,
@@ -198,6 +203,8 @@ object ServerFormUseCases {
198203
}
199204

200205
entityLists.forEach { mediaFile ->
206+
stateListener.progressUpdate(progress++)
207+
201208
val tempMediaFile = File(tempMediaDir, mediaFile.filename)
202209
val entityListName = getEntityListFromFileName(mediaFile)
203210
val localEntityList = entitiesRepository.getList(entityListName)

collect_app/src/test/java/org/odk/collect/android/formmanagement/download/ServerFormDownloaderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,6 @@ public void whenFormHasMediaFiles_andFileExistsInMediaDirPath_throwsDiskExceptio
407407
}
408408

409409
@Test
410-
@Ignore
411410
public void beforeDownloadingEachMediaFile_reportsProgress() throws Exception {
412411
String xform = createXFormBody("id", "version");
413412
ServerFormDetails serverFormDetails = new ServerFormDetails(

0 commit comments

Comments
 (0)