Dependency updates for 2025.4 #6892
Conversation
grzesiek2010
force-pushed
the
dependency_updates_for_2025.4
branch
3 times, most recently
from
abc24b7 to
20b6381
Compare
| .append(getString(org.odk.collect.strings.R.string.dont_have_project)) | ||
| .append(" ") | ||
| .color(getThemeAttributeValue(context, com.google.android.material.R.attr.colorAccent)) { | ||
| .color(getThemeAttributeValue(context, androidx.appcompat.R.attr.colorAccent)) { |
There was a problem hiding this comment.
We should be using a Material color here instead of an AppCompat one I think. Same goes for the other places we're using colorAccent.
There was a problem hiding this comment.
I replaced colorAccent with colorPrimary as colorAccent does not exist in Material 3 but I'm no longer able to use com.google.android.material.R.attr to access it programatically so it looks like I need to use androidx.appcompat.R.attr.
| } | ||
| if (accuracyCircle == null) { | ||
| int stroke = ContextUtils.getThemeAttributeValue(requireContext(), com.google.android.material.R.attr.colorPrimaryDark); | ||
| int stroke = ContextUtils.getThemeAttributeValue(requireContext(), androidx.appcompat.R.attr.colorPrimaryDark); |
There was a problem hiding this comment.
Again, we should take the opportunity here to replace this with a Material Color
There was a problem hiding this comment.
I removed colorPrimaryDark but when it comes to androidx.appcompat.R.attr see above.
open-rosa/src/test/java/org/odk/collect/openrosa/http/OpenRosaPostRequestTest.java
Show resolved
Hide resolved
|
@grzesiek2010 just nudging on this in case it's fallen through the cracks! |
grzesiek2010
force-pushed
the
dependency_updates_for_2025.4
branch
from
20b6381 to
aed52c9
Compare
grzesiek2010
force-pushed
the
dependency_updates_for_2025.4
branch
from
aed52c9 to
81f1cc7
Compare
2 participants
Why is this the best possible solution? Were any other approaches considered?
As usual, I've updated the dependencies for the next release. Nothing special to discuss here.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest