Skip to content

Fix metal feature detection #8439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from
+187 −108
Draft

Fix metal feature detection #8439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5d4a94
Initial commit
inner-daemons Oct 29, 2025
be3e22f
Further commits
inner-daemons Oct 30, 2025
7f8227f
Updated logic again (partial)
inner-daemons Oct 30, 2025
6002579
Now it compiles at least
inner-daemons Oct 30, 2025
fd63db8
Added changelog entry
inner-daemons Oct 30, 2025
15bc395
Fuck this
inner-daemons Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ private = { ignore = true }
[sources]
allow-git = [
# Waiting on releases; used in examples/tests only
"https://github.com/gfx-rs/metal-rs.git"
]
unknown-registry = "deny"
unknown-git = "deny"
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ SamplerDescriptor {

- Fixed a validation error regarding atomic memory semantics. By @atlv24 in [#8391](https://github.com/gfx-rs/wgpu/pull/8391).

#### Metal
- Fixed a variety of feature detection related bugs. By @inner-daemons in [#8439](https://github.com/gfx-rs/wgpu/pull/8439).

#### hal

- `DropCallback`s are now called after dropping all other fields of their parent structs. By @jerzywilczek in [#8353](https://github.com/gfx-rs/wgpu/pull/8353)
Expand Down
3 changes: 1 addition & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ which = "8"
xshell = "0.2.2"

# Metal dependencies
metal = "0.32"
metal = { git = "https://github.com/gfx-rs/metal-rs.git", rev = "65eff6e77ebec23e4c8c171c6a252234f48a0c82" }
block = "0.1.6"
core-graphics-types = "0.2"
objc = "0.2.5"
Expand Down
Loading
Loading