Skip to content

Commit 7987564

Browse files
committed
Make schema for QueryFilter less strict
1 parent 37cba27 commit 7987564

File tree

3 files changed

+23
-2
lines changed

3 files changed

+23
-2
lines changed

lib/init-action.js

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/config/db-config.test.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -442,6 +442,25 @@ test("parseUserConfig - throws a ConfigurationError if the file is not valid YAM
442442
);
443443
});
444444

445+
test("parseUserConfig - validation isn't picky about `query-filters`", (t) => {
446+
const loggedMessages: LoggedMessage[] = [];
447+
const logger = getRecordingLogger(loggedMessages);
448+
449+
t.notThrows(() =>
450+
dbConfig.parseUserConfig(
451+
logger,
452+
"test",
453+
`
454+
query-filters:
455+
- something
456+
- include: foo
457+
- exclude: bar
458+
`,
459+
true,
460+
),
461+
);
462+
});
463+
445464
test("parseUserConfig - throws a ConfigurationError if validation fails", (t) => {
446465
const loggedMessages: LoggedMessage[] = [];
447466
const logger = getRecordingLogger(loggedMessages);

src/db-config-schema.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@
8787
},
8888
{
8989
"$ref": "#/definitions/IncludeQueryFilter"
90-
}
90+
},
91+
{}
9192
]
9293
},
9394
"ExcludeQueryFilter": {

0 commit comments

Comments
 (0)