Merge pull request #39244 from github/repo-sync

Repo sync

Author: docs-bot

.github/workflows/lint-entire-content-data-markdown.yml

@@ -41,7 +41,7 @@ jobs:
           REPORT_AUTHOR: docs-bot
           REPORT_LABEL: broken content markdown report
           REPORT_REPOSITORY: github/docs-content
-        run: npm run post-lints -- --path /tmp/lint-results.json
+        run: npm run lint-report -- --path /tmp/lint-results.json
 
       - uses: ./.github/actions/slack-alert
         if: ${{ failure() && github.event_name != 'workflow_dispatch' }}

data/reusables/contributing/content-linter-rules.md

@@ -64,6 +64,7 @@
 | GHD038 | expired-content | Expired content must be remediated. | warning | expired |
 | GHD039 | expiring-soon | Content that expires soon should be proactively addressed. | warning | expired |
 | [GHD040](https://github.com/github/docs/blob/main/src/content-linter/README.md) | table-liquid-versioning | Tables must use the correct liquid versioning format | error | tables |
+| GHD047 | table-column-integrity | Tables must have consistent column counts across all rows | warning | tables, accessibility, formatting |
 | GHD041 | third-party-action-pinning | Code examples that use third-party actions must always pin to a full length commit SHA | error | feature, actions |
 | GHD042 | liquid-tag-whitespace | Liquid tags should start and end with one whitespace. Liquid tag arguments should be separated by only one whitespace. | error | liquid, format |
 | GHD043 | link-quotation | Internal link titles must not be surrounded by quotations | error | links, url |

next.config.js

@@ -2,9 +2,11 @@ import fs from 'fs'
 import path from 'path'
 
 import frontmatter from 'gray-matter'
-import { languageKeys } from '#src/languages/lib/languages.js'
 import { ROOT } from '#src/frame/lib/constants.js'
 
+// Hard-coded language keys to avoid TypeScript import in config file
+const languageKeys = ['en', 'es', 'ja', 'pt', 'zh', 'ru', 'fr', 'ko', 'de']
+
 const homepage = path.posix.join(ROOT, 'content/index.md')
 const { data } = frontmatter(fs.readFileSync(homepage, 'utf8'))
 const productIds = data.children

package.json

@@ -66,7 +66,7 @@
     "move-content": "tsx src/content-render/scripts/move-content.js",
     "openapi-docs": "tsx src/rest/docs.js",
     "playwright-test": "playwright test --config src/fixtures/playwright.config.ts --project=\"Google Chrome\"",
-    "post-lints": "tsx src/content-linter/scripts/post-lints.js",
+    "lint-report": "tsx src/content-linter/scripts/lint-report.js",
     "postinstall": "cp package-lock.json .installed.package-lock.json && echo \"Updated .installed.package-lock.json\" # see husky/post-checkout and husky/post-merge",
     "precompute-pageinfo": "tsx src/article-api/scripts/precompute-pageinfo.ts",
     "prepare": "husky src/workflows/husky",

src/archives/lib/old-versions-utils.ts

@@ -2,7 +2,7 @@ import path from 'path'
 import { supported, latest } from '@/versions/lib/enterprise-server-releases.js'
 import patterns from '@/frame/lib/patterns.js'
 import nonEnterpriseDefaultVersion from '@/versions/lib/non-enterprise-default-version.js'
-import { allVersions } from '@/versions/lib/all-versions.js'
+import { allVersions } from '@/versions/lib/all-versions'
 const latestNewVersion = `enterprise-server@${latest}`
 const oldVersions = ['dotcom'].concat(supported)
 const newVersions = Object.keys(allVersions)

src/archives/middleware/archived-enterprise-versions.ts

@@ -17,7 +17,7 @@ import {
 } from '@/frame/middleware/set-fastly-surrogate-key.js'
 import { readCompressedJsonFileFallbackLazily } from '@/frame/lib/read-json-file.js'
 import { archivedCacheControl, languageCacheControl } from '@/frame/middleware/cache-control.js'
-import { pathLanguagePrefixed, languagePrefixPathRegex } from '@/languages/lib/languages.js'
+import { pathLanguagePrefixed, languagePrefixPathRegex } from '@/languages/lib/languages'
 import getRedirect, { splitPathByLanguage } from '@/redirects/lib/get-redirect.js'
 import getRemoteJSON from '@/frame/lib/get-remote-json.js'
 import { ExtendedRequest } from '@/types'

src/article-api/scripts/precompute-pageinfo.ts

@@ -30,7 +30,7 @@ import { brotliCompressSync } from 'zlib'
 import chalk from 'chalk'
 import { program, Option } from 'commander'
 
-import { languageKeys } from '@/languages/lib/languages.js'
+import { languageKeys } from '@/languages/lib/languages'
 import { loadPages, loadUnversionedTree } from '@/frame/lib/page-data.js'
 import { CACHE_FILE_PATH, getPageInfo } from '../middleware/article-pageinfo'
 

src/article-api/tests/pagelist.ts

@@ -2,7 +2,7 @@ import { beforeAll, describe, expect, test } from 'vitest'
 
 import { get } from '@/tests/helpers/e2etest.js'
 
-import { allVersionKeys } from '@/versions/lib/all-versions.js'
+import { allVersionKeys } from '@/versions/lib/all-versions'
 import nonEnterpriseDefaultVersion from '@/versions/lib/non-enterprise-default-version.js'
 
 describe.each(allVersionKeys)('pagelist api for %s', async (versionKey) => {

src/audit-logs/lib/index.ts

@@ -1,7 +1,7 @@
 import path from 'path'
 
 import { readCompressedJsonFileFallback } from '@/frame/lib/read-json-file.js'
-import { getOpenApiVersion } from '@/versions/lib/all-versions.js'
+import { getOpenApiVersion } from '@/versions/lib/all-versions'
 import type {
   AuditLogEventT,
   CategorizedEvents,

src/audit-logs/tests/rendering.ts

@@ -1,7 +1,7 @@
 import { describe, expect, test, vi } from 'vitest'
 
 import { getDOM } from '@/tests/helpers/e2etest.js'
-import { allVersions } from '@/versions/lib/all-versions.js'
+import { allVersions } from '@/versions/lib/all-versions'
 import { getCategorizedAuditLogEvents } from '../lib'
 
 describe('audit log events docs', () => {