Skip to content

Commit aa7ebfa

Browse files
authored
Merge pull request #40937 from github/repo-sync
Repo sync
2 parents 30a6b14 + 35cc37c commit aa7ebfa

File tree

7 files changed

+15
-15
lines changed

7 files changed

+15
-15
lines changed

content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/displaying-ip-addresses-in-the-audit-log-for-your-enterprise.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ If members of your enterprise access {% data variables.location.product_location
3636
* Interactions with a resource owned by the personal account, including a repository, gist, or project
3737
* Interactions with a public repository owned by an organization in your enterprise
3838

39-
{% data variables.product.github %} does not display IP address in the audit log for `api.request` events triggered by GraphQL requests.
39+
{% data variables.product.github %} does not display IP addresses in the audit log for `api.request` events that do not have repository context, such as requests triggered by GraphQL or requests to endpoints that reference only a user or organization.
4040

4141
## Enabling display of IP addresses in the audit log
4242

content/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/displaying-ip-addresses-in-the-audit-log-for-your-organization.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ After you enable the feature, you can access the audit log to view events that i
3636

3737
{% data variables.product.github %} displays an IP address for each event in the organization audit log that meets these criteria.
3838

39-
* The actor is an organization member or owner
39+
* The actor is an organization member or owner.
4040
* The target is either an organization-owned repository that is private or internal, or an organization resource that is not a repository, such as a project.
41-
* For `api.request` events, the request was not triggered by GraphQL.
41+
* For `api.request` events, the request must have repository context; requests triggered by GraphQL or to endpoints that reference only a user or organization do not meet this condition.
4242

4343
## Enabling display of IP addresses in the audit log
4444

src/fixtures/fixtures/content/get-started/carousel/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
2-
title: Carousel Test Category
2+
title: Landing Page Carousel
33
intro: 'A test category page for testing the LandingCarousel component.'
44
versions:
55
fpt: '*'
66
ghes: '*'
77
ghec: '*'
8-
layout: category-landing
8+
layout: discovery-landing
99
recommended:
1010
- /category-one/article-one
1111
- /category-one/article-two

src/fixtures/fixtures/content/get-started/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ children:
4141
- /versioning
4242
- /learning-about-github
4343
- /empty-categories
44+
- /test-journey
4445
- /carousel
4546
- /article-grid-discovery
4647
- /article-grid-bespoke

src/fixtures/fixtures/content/test-journey/index.md renamed to src/fixtures/fixtures/content/get-started/test-journey/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
title: Test Journey Landing
2+
title: Journey Landing
33
intro: 'Test page for journey tracks functionality'
44
layout: journey-landing
55
versions:

src/fixtures/fixtures/content/index.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ children:
2626
# as if the URL had been `/en/free-pro-team@latest/get-started/anything`.
2727
- search
2828
- get-started
29-
- test-journey
3029
- early-access
3130
- pages
3231
- code-security

src/fixtures/tests/playwright-rendering.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1008,7 +1008,7 @@ test('open search, Ask AI returns 400 error and shows general search results', a
10081008

10091009
test.describe('LandingCarousel component', () => {
10101010
test('displays carousel on test page', async ({ page }) => {
1011-
await page.goto('/get-started/carousel?feature=discovery-landing')
1011+
await page.goto('/get-started/carousel')
10121012

10131013
const carousel = page.locator('[data-testid="landing-carousel"]')
10141014
await expect(carousel).toBeVisible()
@@ -1026,7 +1026,7 @@ test.describe('LandingCarousel component', () => {
10261026

10271027
test('navigation works on desktop', async ({ page }) => {
10281028
await page.setViewportSize({ width: 1200, height: 800 })
1029-
await page.goto('/get-started/carousel?feature=discovery-landing')
1029+
await page.goto('/get-started/carousel')
10301030

10311031
const carousel = page.locator('[data-testid="landing-carousel"]')
10321032
await expect(carousel).toBeVisible()
@@ -1046,7 +1046,7 @@ test.describe('LandingCarousel component', () => {
10461046

10471047
test('responsive behavior on mobile', async ({ page }) => {
10481048
await page.setViewportSize({ width: 375, height: 667 })
1049-
await page.goto('/get-started/carousel?feature=discovery-landing')
1049+
await page.goto('/get-started/carousel')
10501050

10511051
const carousel = page.locator('[data-testid="landing-carousel"]')
10521052
await expect(carousel).toBeVisible()
@@ -1059,7 +1059,7 @@ test.describe('LandingCarousel component', () => {
10591059

10601060
test.describe('Journey Tracks', () => {
10611061
test('displays journey tracks on landing pages', async ({ page }) => {
1062-
await page.goto('/get-started?feature=journey-landing')
1062+
await page.goto('/get-started/test-journey')
10631063

10641064
const journeyTracks = page.locator('[data-testid="journey-tracks"]')
10651065
await expect(journeyTracks).toBeVisible()
@@ -1075,7 +1075,7 @@ test.describe('Journey Tracks', () => {
10751075
})
10761076

10771077
test('track expansion and collapse functionality', async ({ page }) => {
1078-
await page.goto('/get-started?feature=journey-landing')
1078+
await page.goto('/get-started/test-journey')
10791079

10801080
const firstTrack = page.locator('[data-testid="journey-track"]').first()
10811081
const expandButton = firstTrack.locator('summary')
@@ -1095,7 +1095,7 @@ test.describe('Journey Tracks', () => {
10951095
})
10961096

10971097
test('article navigation within tracks', async ({ page }) => {
1098-
await page.goto('/get-started?feature=journey-landing')
1098+
await page.goto('/get-started/test-journey')
10991099

11001100
const firstTrack = page.locator('[data-testid="journey-track"]').first()
11011101
const expandButton = firstTrack.locator('summary')
@@ -1112,7 +1112,7 @@ test.describe('Journey Tracks', () => {
11121112
})
11131113

11141114
test('preserves version in journey track links', async ({ page }) => {
1115-
await page.goto('/enterprise-cloud@latest/get-started?feature=journey-landing')
1115+
await page.goto('/enterprise-cloud@latest/get-started/test-journey')
11161116

11171117
const firstTrack = page.locator('[data-testid="journey-track"]').first()
11181118
const expandButton = firstTrack.locator('summary')
@@ -1127,7 +1127,7 @@ test.describe('Journey Tracks', () => {
11271127
})
11281128

11291129
test('handles liquid template rendering in track content', async ({ page }) => {
1130-
await page.goto('/get-started?feature=journey-landing')
1130+
await page.goto('/get-started/test-journey')
11311131

11321132
const tracks = page.locator('[data-testid="journey-track"]')
11331133

0 commit comments

Comments
 (0)