Skip to content

Migrate from Karma/Mocha/Chai to Vitest with Playwright browser mode #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 7, 2025
Merged

Migrate from Karma/Mocha/Chai to Vitest with Playwright browser mode #145

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7822ce
Initial plan
Copilot Oct 7, 2025
5b8f9d5
Migrate from Karma/Mocha/Chai to Vitest with Playwright
Copilot Oct 7, 2025
5d11c2b
Remove test backup file and finalize migration
Copilot Oct 7, 2025
1d5afee
Remove matrix strategy and Playwright install steps from workflows
Copilot Oct 7, 2025
ff3d6c3
Install chromium in CI
dgreif Oct 7, 2025
9ce2a3c
Ignore test screenshots
dgreif Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,17 @@ on: [push, pull_request]
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [22, 24]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove this matrix and just use 24

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8b0f8ca. Removed the matrix strategy and now using Node 24 only.

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: ${{ matrix.node-version }}
cache: npm
- name: Install Playwright browsers
run: npx playwright install --with-deps chromium
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I don't think we need to install these deps. Remove npx playwrite install from all workflows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8b0f8ca. Removed npx playwright install from nodejs.yml and publish.yml. The vitest config uses system chromium at /usr/bin/chromium, so no Playwright installation is needed.

- name: npm install, build, and test
run: |
npm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
cache: npm

- run: npm install
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
registry-url: https://registry.npmjs.org/
cache: npm
- run: npx playwright install --with-deps chromium
- run: npm ci
- run: npm test
- run: npm version ${TAG_NAME} --git-tag-version=false
Expand Down
25 changes: 0 additions & 25 deletions karma.config.cjs
View file
Open in desktop

This file was deleted.

Loading