Fix @typescript-eslint/prefer-promise-reject-errors by using asError

Author: robertbrignull

extensions/ql-vscode/src/codeql-cli/cli.ts

@@ -19,6 +19,7 @@ import type { CliConfig } from "../config";
 import type { DistributionProvider } from "./distribution";
 import { FindDistributionResultKind } from "./distribution";
 import {
+  asError,
   assertNever,
   getErrorMessage,
   getErrorStack,
@@ -851,7 +852,7 @@ export class CodeQLCliServer implements Disposable {
             silent,
           ).then(resolve, reject);
         } catch (err) {
-          reject(err);
+          reject(asError(err));
         }
       };
       // If the server is not running a command, then run the given command immediately,

extensions/ql-vscode/src/common/jsonl-reader.ts

@@ -1,6 +1,7 @@
 import { stat } from "fs/promises";
 import { createReadStream } from "fs-extra";
 import type { BaseLogger } from "./logging";
+import { asError } from "./helpers-pure";
 
 const doubleLineBreakRegexp = /\n\r?\n/;
 
@@ -41,7 +42,7 @@ export async function readJsonlFile<T>(
           stream.resume();
         } catch (e) {
           stream.destroy();
-          reject(e);
+          reject(asError(e));
         }
       }
     });
@@ -53,7 +54,7 @@ export async function readJsonlFile<T>(
         void logger?.log(`Finished parsing ${path}`);
         resolve();
       } catch (e) {
-        reject(e);
+        reject(asError(e));
       }
     });
     stream.on("error", reject);

extensions/ql-vscode/src/common/unzip.ts

@@ -5,6 +5,7 @@ import { Transform } from "stream";
 import { dirname, join } from "path";
 import type { WriteStream } from "fs";
 import { createWriteStream, ensureDir } from "fs-extra";
+import { asError } from "./helpers-pure";
 
 // We can't use promisify because it picks up the wrong overload.
 export function openZip(
@@ -47,7 +48,7 @@ export function readZipEntries(zipFile: ZipFile): Promise<ZipEntry[]> {
     });
 
     zipFile.on("error", (err) => {
-      reject(err);
+      reject(asError(err));
     });
   });
 }

extensions/ql-vscode/src/variant-analysis/view-autofixes.ts

@@ -42,7 +42,7 @@ import {
   AUTOFIX_PATH,
   AUTOFIX_MODEL,
 } from "../config";
-import { getErrorMessage } from "../common/helpers-pure";
+import { asError, getErrorMessage } from "../common/helpers-pure";
 import { createTimeoutSignal } from "../common/fetch-stream";
 import { unzipToDirectoryConcurrently } from "../common/unzip-concurrently";
 import { reportUnzipProgress } from "../common/vscode/unzip-progress";
@@ -819,7 +819,7 @@ function execAutofix(
         }
       });
     } catch (e) {
-      reject(e);
+      reject(asError(e));
     }
   });
 }