Fix compiler plugin support for unnamed arguments

Author: gkreitz

src/Compile/Base.php

@@ -69,6 +69,17 @@ protected function formatParamsArray(array $_attr): array {
 		return $_paramsArray;
 	}
 
+	/**
+	 * Returns attribute index for unnamed ("shorthand") attribute, or null if not allowed.
+	 *
+	 * @param int $key
+	 *
+	 * @return string|int|null
+	 */
+	protected function getShorthandOrder(int $key) {
+	    return $this->shorttag_order[$key] ?? null;
+	}
+
 	/**
 	 * This function checks if the attributes passed are valid
 	 * The attributes passed for the tag to compile are checked against the list of required and
@@ -91,8 +102,8 @@ protected function getAttributes($compiler, $attributes) {
 				if (isset($options[trim($mixed, '\'"')])) {
 					$_indexed_attr[trim($mixed, '\'"')] = true;
 					// shorthand attribute ?
-				} elseif (isset($this->shorttag_order[$key])) {
-					$_indexed_attr[$this->shorttag_order[$key]] = $mixed;
+				} elseif (!is_null($this->getShorthandOrder($key))) {
+					$_indexed_attr[$this->getShorthandOrder($key)] = $mixed;
 				} else {
 					// too many shorthands
 					$compiler->trigger_template_error('too many shorthand attributes', null, true);

src/Compile/Tag/BCPluginWrapper.php

@@ -21,11 +21,25 @@ public function __construct($callback, bool $cacheable = true) {
 		$this->cacheable = $cacheable;
 	}
 
+        /**
+         * Returns attribute index for unnamed ("shorthand") attribute, or null if not allowed.
+         *
+         * For compiler plugins, we allow arbitrarily many unnamed attributes,
+         * and just make them accessible in the order they are set.
+         *
+         * @param int $key
+         *
+         * @return int
+         */
+        protected function getShorthandOrder(int $key): int {
+            return $key;
+        }
+
 	/**
 	 * @inheritDoc
 	 */
 	public function compile($args, \Smarty\Compiler\Template $compiler, $parameter = [], $tag = null, $function = null): string
 	{
 		return call_user_func($this->callback, $this->getAttributes($compiler, $args), $compiler->getSmarty());
 	}
-}
+}