Merge pull request #104218 from zaevi/fix_OptimizedTranslation_hash

Repiteo · Repiteo · commit 92002b1c69ba · 2025-04-01T19:53:37.000-05:00
Fix hash issue with OptimizedTranslation caused by signed char
diff --git a/core/string/optimized_translation.h b/core/string/optimized_translation.h
@@ -64,7 +64,7 @@ class OptimizedTranslation : public Translation {
 			d = 0x1000193;
 		}
 		while (*p_str) {
-			d = (d * 0x1000193) ^ uint32_t(*p_str);
+			d = (d * 0x1000193) ^ static_cast<uint8_t>(*p_str);
 			p_str++;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ class OptimizedTranslation : public Translation {`
`64`	`64`	`d = 0x1000193;`
`65`	`65`	`}`
`66`	`66`	`while (*p_str) {`
`67`		`- d = (d * 0x1000193) ^ uint32_t(*p_str);`
	`67`	`+ d = (d * 0x1000193) ^ static_cast<uint8_t>(*p_str);`
`68`	`68`	`p_str++;`
`69`	`69`	`}`
`70`	`70`