Use Span to reduce allocations in HTTPClientTCP::poll
#104929
+30
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiroxas
changed the title
kiroxas
force-pushed
the
pollAllocations
branch
2 times, most recently
from
98317fc to
5159a8a
Compare
Ivorforce
reviewed
Apr 2, 2025
kiroxas
force-pushed
the
pollAllocations
branch
2 times, most recently
from
ede3568 to
26988b1
Compare
Ivorforce
approved these changes
Apr 4, 2025
| const int index = std::size(transferEncodingLabel) - 1; | ||
| Span<char32_t> sp = Span<char32_t>(s.ptr() + index, s.length() - index); | ||
| sp = String::strip_edges_span(sp, true, true); | ||
| if (String("chunked") == sp) { |
Member
There was a problem hiding this comment.
This shouldn't need to allocate a String. However, my equality operator PR is still outstanding, so I think it's acceptable for the moment.
Contributor
Author
There was a problem hiding this comment.
yeah, it would be better to not have to construct the string, but we can't right now. We can update this if your PR is merged.
akien-mga
changed the title
HTTPClientTCP::poll
kiroxas
commented
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted during this PR.
Used span to avoid some substring allocations. Avoid find that could be done at compile time. Remove useless push_back, parse_utf8 does not have to be 0 terminated.
Extracted strip_edges logic into a static function, to be able to call it with span and strings (without the need to allocate a string).
The name may not be very good, but naming it strip_edges brought conflict with Variant, probably because the name is bound.
Maybe we should come up with a long term solution for this because I guess the need will arise with other functions (applying strings functions to span created from strings).