Skip to content

Conversation

@Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jul 27, 2025

Replaces the legacy --editor --quit syntax with --import when running the Godot Test Project action. Could potentially also apply --headless, but its exclusion might be by design?

@Repiteo Repiteo added this to the 4.x milestone Jul 27, 2025
@Repiteo Repiteo requested a review from a team as a code owner July 27, 2025 15:26
@Repiteo Repiteo force-pushed the ci/import-syntax branch from 8a82747 to c52c91f Compare July 27, 2025 22:58
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Repiteo Repiteo modified the milestones: 4.x, 4.5 Jul 28, 2025
@Repiteo Repiteo merged commit f7ced47 into godotengine:master Jul 28, 2025
20 checks passed
@Repiteo Repiteo deleted the ci/import-syntax branch July 28, 2025 15:56
Handagotes pushed a commit to Handagotes/godot that referenced this pull request Jul 30, 2025
@Calinou
Copy link
Member

Calinou commented Jul 31, 2025

Could potentially also apply --headless, but its exclusion might be by design?

Yes, it's likely by design for two reasons:

  • We want to test the editor's graphical codepaths (CI has llvmpipe configured, so it works without a physical GPU in place).
  • There are some bugs in --headless import, e.g. when using global/per-instance shader parameters. This is what GitHub Actions: Test project exporting on CI #109146 aims to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants