test: improve task completion metrics and testing in Queue module

appleboy · appleboy · commit 811fe1ad0dd6 · 2025-01-19T14:09:12.000+08:00
- Add assertion for completed tasks in `TestMetricData` test
- Increment completed tasks metric in `work` function of `Queue`

Signed-off-by: appleboy &lt;appleboy.tw@gmail.com&gt;
diff --git a/metric_test.go b/metric_test.go
@@ -47,5 +47,6 @@ func TestMetricData(t *testing.T) {
 	assert.Equal(t, uint64(4), q.SubmittedTasks())
 	assert.Equal(t, uint64(2), q.SuccessTasks())
 	assert.Equal(t, uint64(2), q.FailureTasks())
+	assert.Equal(t, uint64(4), q.CompletedTasks())
 	q.Release()
 }
diff --git a/queue.go b/queue.go
@@ -173,6 +173,7 @@ func (q *Queue) work(task core.QueuedMessage) {
 		if q.afterFn != nil {
 			q.afterFn()
 		}
+		q.metric.IncCompletedTask()
 	}()
 
 	if err = q.run(task); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -47,5 +47,6 @@ func TestMetricData(t *testing.T) {`
`47`	`47`	`assert.Equal(t, uint64(4), q.SubmittedTasks())`
`48`	`48`	`assert.Equal(t, uint64(2), q.SuccessTasks())`
`49`	`49`	`assert.Equal(t, uint64(2), q.FailureTasks())`
	`50`	`+ assert.Equal(t, uint64(4), q.CompletedTasks())`
`50`	`51`	`q.Release()`
`51`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -173,6 +173,7 @@ func (q *Queue) work(task core.QueuedMessage) {`
`173`	`173`	`if q.afterFn != nil {`
`174`	`174`	`q.afterFn()`
`175`	`175`	`}`
	`176`	`+ q.metric.IncCompletedTask()`
`176`	`177`	`}()`
`177`	`178`
`178`	`179`	`if err = q.run(task); err != nil {`