-
Notifications
You must be signed in to change notification settings - Fork 18.5k
cmd/go/internal/tool: include dynamically buildable tools #76042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This PR (HEAD: 5a39834) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714560. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714560. |
|
Message from Michael Matloob: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/714560. |
`go tool` only listed binaries already built into `pkg/tool`, so users couldn't discover builtin tools that can be built on demand. Extend the listing to include cmd/ tools that can be built with the current toolchain while avoiding duplicates and keeping the output sorted. For golang#75960 Change-Id: I32b0f5ae6cd2c67cf3af465ffb5b4ac3d446ded4
|
Message from Prince Roshan: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714560. |
5a39834 to
0784336
Compare
|
This PR (HEAD: 0784336) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714560. Important tips:
|
|
Message from Prince Roshan: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/714560. |
go toolonly listed binaries already built intopkg/tool, so userscouldn't discover builtin tools that can be built on demand. Extend the
listing to include cmd/ tools that can be built with the current
toolchain while avoiding duplicates and keeping the output sorted.
Fixes #75960