Validator for profile_conditions #1630
Conversation
MateoBell
force-pushed
the
imas_validators
branch
from
c15a2b4 to
1e93d3b
Compare
| import torax._src.constants as constants | ||
|
|
||
| _PROFILE_CONDITIONS_REQUIRED_FIELDS = { | ||
| "gloabl_quantities": ["ip", "v_loop"], |
There was a problem hiding this comment.
are there any constants from the imas-python library that can be referred to here instead of us using literal strings?
There was a problem hiding this comment.
@mikesndrs can I ask your input on this ? Do you know if it exists in imas-python ?
| for field in _PROFILE_CONDITIONS_REQUIRED_FIELDS["gloabl_quantities"]: | ||
| if not getattr(global_quantities, field): | ||
| # Warning or critical ? | ||
| logging.critical( |
There was a problem hiding this comment.
I believe we'd want to raise an error here with an informative error message that the expected field is missing.
There was a problem hiding this comment.
Not entirely sure about this. For geometry loader I think we'd want to raise an error but with core_profiles not necessarily. There might be cases where we want to load partially some profiles but not all from an IDS, like only electrons ones or ions ones and get the rest from elsewhere / prescribe it. In this case, it does not matter that the other fields are empty in the input IDS. Do you agree ?
There was a problem hiding this comment.
Ah ok, yeah that makes sense. I think it would be good to converge on a minimal set of required attributes for using the profile_conditions_from_IMAS function though as that makes assumptions on certain fields being present?
2 participants
Add validators for the IMAS function to check that the required fields are properly filled in the input IDS and if not provide a clear warning.
Closes #1610.
Validation functions:
Integration