Skip to content

Commit 59d422c

Browse files
jsorefcopybara-github
authored andcommitted
chore: Fix spelling in contributing
Merge #3394 This PR corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling) Note: while I use tooling to identify errors, the tooling doesn't _actually_ provide the corrections, I'm picking them on my own. I'm a human, and I may make mistakes. ### Testing Plan The misspellings have been reported at https://github.com/jsoref/adk-python/actions/runs/19056081305/attempts/1#summary-54426435973 The action reports that the changes in this PR would make it happy: https://github.com/jsoref/adk-python/actions/runs/19056081446/attempts/1#summary-54426436321 **Unit Tests:** - [ ] I have added or updated unit tests for my change. - [ ] All unit tests pass locally. _Please include a summary of passed `pytest` results._ **Manual End-to-End (E2E) Tests:** _Please provide instructions on how to manually test your changes, including any necessary setup or configuration. Please provide logs or screenshots to help reviewers better understand the fix._ ### Checklist - [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document. - [x] I have performed a self-review of my own code. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] New and existing unit tests pass locally with my changes. - [ ] I have manually tested my changes end-to-end. - [ ] Any dependent changes have been merged and published in downstream modules. ### Additional context - #3382 (comment) COPYBARA_INTEGRATE_REVIEW=#3394 from jsoref:spelling-contributing c3d5e34 PiperOrigin-RevId: 828659867
1 parent a2ce34a commit 59d422c

File tree

30 files changed

+52
-52
lines changed

30 files changed

+52
-52
lines changed

contributing/samples/adk_agent_builder_assistant/tools/search_adk_source.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ async def search_adk_source(
4646
max_results: Maximum number of results to return (default: 20)
4747
context_lines: Number of context lines to include around matches (default:
4848
3)
49-
case_sensitive: Whether search should be case sensitive (default: False)
49+
case_sensitive: Whether search should be case-sensitive (default: False)
5050
5151
Returns:
5252
Dict containing search results:

contributing/samples/adk_agent_builder_assistant/tools/write_config_files.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ async def write_config_files(
6666
6767
Args:
6868
configs: Dict mapping file_path to config_content (YAML as string)
69-
backup_existing: Whether to create timest amped backup of existing files
69+
backup_existing: Whether to create timestamped backup of existing files
7070
before overwriting (default: False, User should decide)
7171
create_directories: Whether to create parent directories if they don't exist
7272
(default: True)

contributing/samples/adk_answering_agent/agent.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
6262
3. **Decide whether to respond**:
6363
* If all the following conditions are met, try to add a comment to the
64-
discussion, otherwise, do not respond:
64+
discussion; otherwise, do not respond:
6565
- The discussion is not closed.
6666
- The latest comment is not from you or other agents (marked as
6767
"Response from XXX Agent").
@@ -102,7 +102,7 @@
102102
* You **should always** use the `convert_gcs_links_to_https` tool to convert
103103
GCS links (e.g. "gs://...") to HTTPS links.
104104
* **Do not** use the `convert_gcs_links_to_https` tool for non-GCS links.
105-
* Make sure the citation URL is valid. Otherwise do not list this specific
105+
* Make sure the citation URL is valid. Otherwise, do not list this specific
106106
citation.
107107
* Do not respond to any other discussion except the one specified by the user.
108108

contributing/samples/adk_answering_agent/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def convert_gcs_to_https(gcs_uri: str) -> Optional[str]:
128128

129129
base_url = "https://google.github.io/adk-docs/"
130130
if os.path.basename(path_after_docs) == "index.md":
131-
# Use the directory path if it is a index file
131+
# Use the directory path if it is an index file
132132
final_path_segment = os.path.dirname(path_after_docs)
133133
else:
134134
# Otherwise, use the file name without extension

contributing/samples/adk_documentation/adk_docs_updater/agent.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@
5454
),
5555
instruction=f"""
5656
# 1. Identity
57-
You are a helper bot that updates ADK docs in Github Repository {DOC_OWNER}/{DOC_REPO}
58-
based on the code in the ADK Python codebase in Github Repository {CODE_OWNER}/{CODE_REPO} according to the instructions in the ADK docs issues.
57+
You are a helper bot that updates ADK docs in GitHub Repository {DOC_OWNER}/{DOC_REPO}
58+
based on the code in the ADK Python codebase in GitHub Repository {CODE_OWNER}/{CODE_REPO} according to the instructions in the ADK docs issues.
5959
60-
You are very familiar with Github, expecially how to search for files in a Github repository using git grep.
60+
You are very familiar with GitHub, especially how to search for files in a GitHub repository using git grep.
6161
6262
# 2. Responsibilities
6363
Your core responsibility includes:
@@ -69,18 +69,18 @@
6969
# 3. Workflow
7070
1. Always call the `clone_or_pull_repo` tool to make sure the ADK docs and codebase repos exist in the local folder {LOCAL_REPOS_DIR_PATH}/repo_name and are the latest version.
7171
2. Read and analyze the issue specified by user.
72-
- If user only specified the issue number, call the `get_issue` tool to get the issue details, otherwise use the issue details provided by user directly.
72+
- If user only specified the issue number, call the `get_issue` tool to get the issue details; otherwise, use the issue details provided by user directly.
7373
3. If the issue contains instructions about how to update the ADK docs, follow the instructions to update the ADK docs.
7474
4. Understand the doc update instructions.
7575
- Ignore and skip the instructions about updating API reference docs, since it will be automatically generated by the ADK team.
7676
5. Read the doc to update using the `read_local_git_repo_file_content` tool from the local ADK docs repo under {LOCAL_REPOS_DIR_PATH}/{DOC_REPO}.
7777
6. Find the related Python files in the ADK Python codebase.
78-
- If the doc update instructions specify paths to the Python files, use them directly, otherwise use a list of regex search patterns to find the related Python files through the `search_local_git_repo` tool.
78+
- If the doc update instructions specify paths to the Python files, use them directly; otherwise, use a list of regex search patterns to find the related Python files through the `search_local_git_repo` tool.
7979
- You should focus on the main ADK Python codebase, ignore the changes in tests or other auxiliary files.
8080
- You should find all the related Python files, not only the most relevant one.
8181
7. Read the specified or found Python files using the `read_local_git_repo_file_content` tool to find all the related code.
82-
- You can ignore unit test files, unless you are sure that the test code is uesful to understand the related concepts.
83-
- You should read all the the found files to find all the related code, unless you already know the content of the file or you are sure that the file is not related to the ADK doc.
82+
- You can ignore unit test files, unless you are sure that the test code is useful to understand the related concepts.
83+
- You should read all the found files to find all the related code, unless you already know the content of the file or you are sure that the file is not related to the ADK doc.
8484
8. Update the ADK doc file according to the doc update instructions and the related code.
8585
- Use active voice phrasing in your doc updates.
8686
- Use second person "you" form of address in your doc updates.
@@ -102,7 +102,7 @@
102102
- **File Paths:** Always use absolute paths when calling the tools to read files, list directories, or search the codebase.
103103
- **Tool Call Parallelism:** Execute multiple independent tool calls in parallel when feasible (i.e. searching the codebase).
104104
- **Avoid deletion:** Do not delete any existing content unless specifically directed to do so.
105-
- **Explaination:** Provide concise explanations for your actions and reasoning for each step.
105+
- **Explanation:** Provide concise explanations for your actions and reasoning for each step.
106106
- **Minimize changes:** When making updates to documentation pages, make the minimum amount of changes to achieve the communication goal. Only make changes that are necessary, and leave everything else as-is.
107107
- **Avoid trivial code sample changes:** Update code samples only when adding or modifying functionality. Do not reformat code samples, change variable names, or change code syntax unless you are specifically directed to make those updates.
108108

contributing/samples/adk_documentation/adk_release_analyzer/agent.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,17 +56,17 @@
5656
),
5757
instruction=f"""
5858
# 1. Identity
59-
You are a helper bot that checks if ADK docs in Github Repository {DOC_REPO} owned by {DOC_OWNER}
60-
should be updated based on the changes in the ADK Python codebase in Github Repository {CODE_REPO} owned by {CODE_OWNER}.
59+
You are a helper bot that checks if ADK docs in GitHub Repository {DOC_REPO} owned by {DOC_OWNER}
60+
should be updated based on the changes in the ADK Python codebase in GitHub Repository {CODE_REPO} owned by {CODE_OWNER}.
6161
62-
You are very familiar with Github, expecially how to search for files in a Github repository using git grep.
62+
You are very familiar with GitHub, especially how to search for files in a GitHub repository using git grep.
6363
6464
# 2. Responsibilities
6565
Your core responsibility includes:
6666
- Find all the code changes between the two ADK releases.
6767
- Find **all** the related docs files in ADK Docs repository under the "/docs/" directory.
6868
- Compare the code changes with the docs files and analyze the differences.
69-
- Write the instructions about how to update the ADK docs in markdown format and create a Github issue in the Github Repository {DOC_REPO} with the instructions.
69+
- Write the instructions about how to update the ADK docs in markdown format and create a GitHub issue in the GitHub Repository {DOC_REPO} with the instructions.
7070
7171
# 3. Workflow
7272
1. Always call the `clone_or_pull_repo` tool to make sure the ADK docs and codebase repos exist in the local folder {LOCAL_REPOS_DIR_PATH}/repo_name and are the latest version.
@@ -102,8 +102,8 @@
102102
**Reference**:
103103
Reference to the code file (e.g. src/google/adk/tools/spanner/metadata_tool.py).
104104
```
105-
- When referncing doc file, use the full relative path of the doc file in the ADK Docs repository (e.g. docs/sessions/memory.md).
106-
9. Create or recommend to create a Github issue in the Github Repository {DOC_REPO} with the instructions using the `create_issue` tool.
105+
- When referencing doc file, use the full relative path of the doc file in the ADK Docs repository (e.g. docs/sessions/memory.md).
106+
9. Create or recommend to create a GitHub issue in the GitHub Repository {DOC_REPO} with the instructions using the `create_issue` tool.
107107
- The title of the issue should be "Found docs updates needed from ADK python release <start_tag> to <end_tag>", where start_tag and end_tag are the release tags.
108108
- The body of the issue should be the instructions about how to update the ADK docs.
109109
- Include the compare link between the two ADK releases in the issue body, e.g. https://github.com/google/adk-python/compare/v1.14.0...v1.14.1.
@@ -112,7 +112,7 @@
112112
# 4. Guidelines & Rules
113113
- **File Paths:** Always use absolute paths when calling the tools to read files, list directories, or search the codebase.
114114
- **Tool Call Parallelism:** Execute multiple independent tool calls in parallel when feasible (i.e. searching the codebase).
115-
- **Explaination:** Provide concise explanations for your actions and reasoning for each step.
115+
- **Explanation:** Provide concise explanations for your actions and reasoning for each step.
116116
- **Reference:** For each recommended change, reference the code changes (i.e. links to the commits) **AND** the code files (i.e. relative paths to the code files in the codebase).
117117
- **Sorting:** Sort the recommended changes by the importance of the changes, from the most important to the least important.
118118
- Here are the importance groups: Feature changes > Bug fixes > Other changes.

contributing/samples/adk_documentation/tools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ def get_issue(
392392
Args:
393393
repo_owner: The name of the repository owner.
394394
repo_name: The name of the repository.
395-
issue_number: issue number of the Github issue.
395+
issue_number: issue number of the GitHub issue.
396396
397397
Returns:
398398
The status of this request, with the issue details when successful.

contributing/samples/adk_issue_formatting_agent/agent.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
BUG_REPORT_TEMPLATE = read_file(
3030
Path(__file__).parent / "../../../../.github/ISSUE_TEMPLATE/bug_report.md"
3131
)
32-
FREATURE_REQUEST_TEMPLATE = read_file(
32+
FEATURE_REQUEST_TEMPLATE = read_file(
3333
Path(__file__).parent
3434
/ "../../../../.github/ISSUE_TEMPLATE/feature_request.md"
3535
)
@@ -145,7 +145,7 @@ def list_comments_on_issue(issue_number: int) -> dict[str, any]:
145145
# 2. CONTEXT & RESOURCES
146146
* **Repository:** You are operating on the GitHub repository `{OWNER}/{REPO}`.
147147
* **Bug Report Template:** (`{BUG_REPORT_TEMPLATE}`)
148-
* **Feature Request Template:** (`{FREATURE_REQUEST_TEMPLATE}`)
148+
* **Feature Request Template:** (`{FEATURE_REQUEST_TEMPLATE}`)
149149
150150
# 3. CORE MISSION
151151
Your goal is to check if a GitHub issue, identified as either a "bug" or a "feature request,"

contributing/samples/adk_pr_triaging_agent/agent.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def add_comment_to_pr(pr_number: int, comment: str) -> dict[str, Any]:
248248
- If it's about tracing, label it with "tracing".
249249
- If it's agent orchestration, agent definition, label it with "core".
250250
- If it's about Model Context Protocol (e.g. MCP tool, MCP toolset, MCP session management etc.), label it with "mcp".
251-
- If you can't find a appropriate labels for the PR, follow the previous instruction that starts with "IMPORTANT:".
251+
- If you can't find an appropriate labels for the PR, follow the previous instruction that starts with "IMPORTANT:".
252252
253253
Here is the contribution guidelines:
254254
`{CONTRIBUTING_MD}`

contributing/samples/adk_triaging_agent/agent.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ def change_issue_type(issue_number: int, issue_type: str) -> dict[str, Any]:
214214
- Use "agent engine" only when the issue clearly references Vertex AI Agent Engine deployment artifacts (for example `.agent_engine_config.json`, `ae_ignore`, `agent_engine_id`, or Agent Engine sandbox errors).
215215
- If it's about Model Context Protocol (e.g. MCP tool, MCP toolset, MCP session management etc.), label it with both "mcp" and "tools".
216216
- If it's about A2A integrations or workflows, label it with "a2a".
217-
- If you can't find a appropriate labels for the issue, follow the previous instruction that starts with "IMPORTANT:".
217+
- If you can't find an appropriate labels for the issue, follow the previous instruction that starts with "IMPORTANT:".
218218
219219
Call the `add_label_and_owner_to_issue` tool to label the issue, which will also assign the issue to the owner of the label.
220220

0 commit comments

Comments
 (0)