-
Notifications
You must be signed in to change notification settings - Fork 448
Description
Description
This is a preparation to fully migrate to Bazel in macOS and Windows builds.
Currently mozc::CrashReportHandler to catch runtime crash to generate minidump with breakpad is supported only in the GYP build with branding=GoogleJapaneseInput. This is one of non-trivial behavior differences between the Bazel build and GYP build right now.
To make both builds consistent, basically there are two choices.
- A. Enable
mozc::CrashReportHandlerfor Bazel build withbranding=GoogleJapaneseInput - B. Remove
mozc::CrashReportHandlerfrom both GYP and Bazel build even withbranding=GoogleJapaneseInput
What I would propose is to go for B, because
- Minidump analysis is not actively performed these days actually.
mozc::CrashReportHandlerneeds to be updated to support ARM64 on macOS and Windows.- Chromium has already switched to
crashpadfrombreakpad. There is a long standing TODO bug to see if Mozc can also switch tocrashpad, which has never been realized. - By removing
mozc::CrashReportHandler, we can of course remove the dependency onbreakpad.
Expected behavior
src/base/crash_report_handler*are removed.src/third_party/breakpadis removed.src/data/installer/credits_en.htmlno longer mentions aboutgoogle-breakpad.
Version or commit-id
Environment
- OS: Windows and macOS
Additional context
There must be no observable behavior change when branding=Mozc anyway, as we have never enabled crash reporting in the OSS builds.