feat: always store volume rendering depth samples in JSON state if volume rendering is enabled #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'd be inclined to bump the default for new layers but not modify existing states. |
seankmartin
changed the title
Contributor
Author
|
Thanks @jbms, I changed the scope of this PR to instead focus on always storing the number of depth samples from volume rendering in the JSON state if volume rendering is enabled. So now the JSON state should contain the number of volume rendering samples if it was either changed from the default, or never changed from the default, but volume rendering is active. This should allow us to make future changes to the volume rendering number of samples more readily without affecting existing states that have volume rendering in use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always store the number of depth samples from volume rendering in the JSON state if volume rendering is enabled. Now the JSON state should contain the number of volume rendering samples if it was either changed from the default, or never changed from the default, but volume rendering is active.
This should allow us to make future changes to the volume rendering number of samples more readily without affecting existing states that have volume rendering in use.